sesparse: Accept reserved1 0x200 in seSparse headers#1
Open
roamingengineer311 wants to merge 1 commit into
Open
sesparse: Accept reserved1 0x200 in seSparse headers#1roamingengineer311 wants to merge 1 commit into
roamingengineer311 wants to merge 1 commit into
Conversation
Signed-off-by: Dmitrii Gilev <dgilev@opennebula.io>
3 tasks
rsmontero
pushed a commit
to OpenNebula/website
that referenced
this pull request
May 21, 2026
…663) ### Description Adds a known issue for OneSwap delta migration on vCenter/ESXi 8 and newer. Delta migration may fail because the `sesparse` tool used to apply VMware `seSparse` snapshot deltas was tested against older vCenter/ESXi versions. The known issue points users to the upstream fix: - storpool/any2kvm#1 It also notes that `sesparse` needs to be rebuilt with that patch and installed in `/usr/bin/` on the conversion host. ### Branches to which this PR applies - [x] master - [x] one-7.2 - [X] one-7.2-maintenance --------- Signed-off-by: Dmitrii Gilev <dgilev@opennebula.io> Co-authored-by: mattrowe-opennebula <mrowe@opennebula.io>
rsmontero
pushed a commit
to OpenNebula/website
that referenced
this pull request
May 21, 2026
…663) ### Description Adds a known issue for OneSwap delta migration on vCenter/ESXi 8 and newer. Delta migration may fail because the `sesparse` tool used to apply VMware `seSparse` snapshot deltas was tested against older vCenter/ESXi versions. The known issue points users to the upstream fix: - storpool/any2kvm#1 It also notes that `sesparse` needs to be rebuilt with that patch and installed in `/usr/bin/` on the conversion host. ### Branches to which this PR applies - [x] master - [x] one-7.2 - [X] one-7.2-maintenance --------- Signed-off-by: Dmitrii Gilev <dgilev@opennebula.io> Co-authored-by: mattrowe-opennebula <mrowe@opennebula.io> (cherry picked from commit 9208995)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current validation only accepts
reserved1 = 0, so these snapshots fail immediately with:This change accepts reserved1 values of either 0 or 0x200, while leaving the rest of the header validation unchanged.
Tested with an ESXi-generated seSparse snapshot. Before the change, sesparse failed during header validation. After the change, it reads the grain directory and applies the delta to the raw parent disk.