chore: suppress module-not-found warnings for storm-core qualified exports - #441
Merged
Merged
Conversation
…ports The impl packages are exported to Storm's sibling modules only. Those siblings depend on storm-core, so none of them are observable while storm-core itself compiles and javac emits a "module not found" warning for every qualified-export target. Annotate the module declaration with @SuppressWarnings("module") to keep the build output clean; the exports resolve as intended once the siblings compile with storm-core on their module path.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building storm-core prints a wall of
[WARNING] module not found: storm.h2(and 20 more) because its impl packages are exported to Storm's sibling modules only. Those siblings depend on storm-core, so none of them are observable while storm-core itself compiles, and javac warns for every qualified-export target it cannot see. The exports themselves work as intended: targets are resolved lazily, so the siblings get access once they compile with storm-core on their module path.This annotates the module declaration with
@SuppressWarnings("module"), which suppresses exactly this lint category for exactly this descriptor. No compiler flags change, so any other module-related warnings elsewhere still surface.storm-kotlin is the only other module with a qualified export (
st.orm.template.impl to kotlin.reflect), but it alsorequires kotlin.reflect, so that target is observable and never warned.Verified with a clean
mvn compileof storm-core: the warnings are gone.