Updated desktop file to allow Nautilus to use qcomicbook to open cbr files#30
Open
Yutsa wants to merge 2 commits into
Open
Updated desktop file to allow Nautilus to use qcomicbook to open cbr files#30Yutsa wants to merge 2 commits into
Yutsa wants to merge 2 commits into
Conversation
This will allow Nautilus to detect qcomicbook as a program to open .cbr files by default. It simply says that the qcomicbook command can take up to one URL parameter. Maybe it should be %U to allow multiple URLs but I didn't see the need for it.
Icons located in /usr/share/pixmaps should not specify the extension now.
|
Hi @Yutsa, I'm not QComicBook developer, although I was almost to submit a similar PR. Your changes mostly look good, although I spot an issue with the placeholder for See the Desktop Entry Specification, for reference: |
plntyk
added a commit
to plntyk/QComicBook
that referenced
this pull request
May 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I downloaded
qcomicbooktoday on my Debian testing machine and I couldn't make Nautilus use it to open my cbr files by default.Although the desktop file specify the right MIME types, the Exec property doens't take any arguments.
I changed it so so that it can take up to one URL. This allows Nautilus to detect
qcomicbookas a program that can open the cbr file.I also removed the
pngextension to the icon name, as it is not necessary and will give an error in the next gnome releases for icons in/usr/share/pixmapsWe also have the possibility to take multiple URLs as argument but I didn't know if it was useful so I didn't.
If it is useful it's a small change, juste change
%uto%U.Another thing that may not be related to the project directly, but
qcomicbookdoesn't have any screenshot preview on itsgnome-softwarepage on Debian. I don't know if it is something you can change though.