Repository navigation
Four things #60 left behind - #77
Merged
Merged
Conversation
#60 merged with five non-blocking review comments unaddressed. Four were defects on main rather than preferences, and the author will not return to them now the pull request is closed. - Both docstrings had replaced their dated capture records with prose. Review thread 3992216374 asked for the 4.0.1 captured shape to stay; it did not. Restored, with the session and frame numbers measured on 2026-09-21. - docs/protocol.md section 10.2 printed the MOVE shape without is_downloads while the coverage table two thousand lines later said the flag is present. One document, two shapes. Section 10.2 now carries it, plus the measured asymmetry: present and false on MOVE, absent from the DELETE in the same session. - delete_preset and move_preset took an unannotated preset. The package ships py.typed, so dropping `name: str` silently removed a guard from every downstream caller: delete_preset(Setlist.USER, 42) type-checked and sent a delete for a preset named "42". Both declare `str | ProductData` again, verified by running mypy over a caller that passes an int. - test_move_preset_matches_the_captured_cortex_builder_bytes claimed a provenance its bytes do not have; they are what the lines above them build. Renamed to what it pins, with the capture it was measured against named. Also restores the by-name form in the silent-transport test. That form is the only one the repository calls (tests/hardware/conftest.py teardown) and a silent device is the case it exists for, so covering only the ProductData form left the hole open. This one was review comment five and is beyond the four agreed; drop it if you would rather it went separately. Evidence for the wire claims is the three recorded CorOS 4.0.1 sessions: one MOVE at session 02 frame 25825, one DELETE at session 02 frame 19033, and 784 of 784 occupied preset-setlist entries keyed <setlist>/<name>.pb.
Four findings from /triage-pr on 3713a32, three of them repo-rule breaches. The blocker was mine: the restored MOVE record gained is_factory: false alongside is_downloads, and the evidence sentence named only is_downloads. In this repository an unevidenced wire assertion is a defect whether or not it is true. Decoding session 02 frame 25825 and frame 19033 settles it - is_factory is explicitly present and false on BOTH captured messages, and to_folder carries neither flag. The claim was right and its evidence was not, so the record now states both flags in a table and says what to_folder omits. The delete_preset coverage row said "three Cortex Control 4.0.1 captures". The three sessions hold one DELETE. The three-session evidence is about listing keys, not about DELETE messages, and the Verified-by column is where evidence strength is declared. Split into "one captured DELETE + three-session key evidence". The move_preset row gained is_factory for the same reason the block did. Both docstrings gave a date and no count, so a reader could not tell the MOVE shape rests on a single frame. Each now names its capture. The changelog carried two Unreleased entries for the same change, the second narrating what the first got wrong. Both are unreleased, so both are editable, and writing.md says a correction replaces the wrong sentence rather than sitting beside it. Folded into one entry, which also drops a docs/protocol.md mention: that file is not in the wheel, and the changelog is for someone who installs the package. Findings on the loop variable shadowing a module import, to_position staying unannotated, SetlistPosition.is_downloads 800 lines away, and the two-clause evidence tag are dismissed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
#60 merged with five non-blocking review comments unaddressed. Four of them were defects on
mainrather than preferences, and the author will not be coming back to them now the pull request is closed. This fixes those four.The four
docs/protocol.mdsection 10.2 printed theMOVEshape withoutis_downloads, while the coverage row said the flag is present. One document, two shapes.delete_presetandmove_presettook an unannotatedpreset.str | ProductDataagain.test_move_preset_matches_the_captured_cortex_builder_bytesclaimed a provenance its bytes do not have.On 3, the guard it removed. The package ships
py.typed, so droppingname: strsilently cost every downstream caller a check.delete_preset(Setlist.USER, 42)type-checked and sent a delete for a preset named42, which_file_operationthen swallowed. Verified by running mypy over a caller that passes an int: twoarg-typeerrors before #60, none after it, two again now.One thing beyond the agreed four
The silent-transport test (
test_file_operations_do_not_raise_when_the_device_stays_silent) had been narrowed to theProductDataform. The by-name form is the only one this repository calls -tests/hardware/conftest.pyteardown - and a silent device is exactly the case that test exists for, so the hole was on the path that matters. Same file, same theme, so it is here. Say the word and I will split it out.Evidence
The three recorded CorOS 4.0.1 sessions hold one
MOVE(session 02, frame 25825) and oneDELETE(session 02, frame 19033). Decoded 2026-09-21:DELETEMOVEfolder.is_factoryfolder.is_downloadsto_folder.is_factoryto_folder.is_downloadsSeparately, 784 of 784 device-reported occupied preset-setlist entries across all three sessions are keyed
<setlist>/<name>.pb, zero mismatches.That key-shape rule holds for preset setlists only. In the same captures, Neural Capture folders report 8248 named entries keyed by bare 64-hex hash. That scope limit is not documented anywhere and is not addressed here - it is a separate question about whether
delete_presetshould accept a capture-folder key at all.Triage round
/triage-pron3713a32found one blocker and three repo-rule breaches, all fixed inc86a376:MOVErecord gainedis_factory: falsewhile the evidence sentence named onlyis_downloads- an unevidenced wire assertion, which is a defect here whether or not it is true. Decoding both frames settled it:is_factoryis explicitly present and false on both captured messages, andto_foldercarries neither flag. The claim was right and its evidence was not, so the record now states both and says whatto_folderomits.delete_presetcoverage row said "three Cortex Control 4.0.1 captures". The three sessions hold oneDELETE; the three-session evidence is about listing keys. Split into "one capturedDELETE+ three-session key evidence".MOVEshape was invisible. Each now names its capture.## Unreleasedchangelog entries described the same change, the second narrating what the first got wrong. Both unreleased, so both editable, andwriting.mdsays a correction replaces the wrong sentence. Folded into one.Four findings dismissed: a loop variable shadowing an unused import,
to_positionstaying unannotated (consistent withsave_current_preset),SetlistPosition.is_downloads800 lines away, and a two-clause evidence tag.Validation
mypy pyquadcortex: clean, 46 source files.c86a376), CorOS 4.0.1, maintainer unit:Nothing here changes what goes on the wire, and the byte-for-byte
MOVEserialization test pins that.Not changed
docs/STEERING.md,CLAUDE.mdanddocs/ADR.mdare untouched. Nothing here changes a decision, an owned path or an architectural rule - it restores records and an annotation that a merged pull request removed. STEERING section 5 already carries "Evidence in docstrings" as a named pattern withclient.pyas its example; this restores that pattern rather than changing it.🤖 Generated with Claude Code