Repository navigation
docs: the operation coverage table names its profile - #56
Merged
Merged
Conversation
…f the file The header still promised that every operation was exercised on firmware d14e, CorOS 4.0.1, which stopped being the rule when ADR-0020 landed. The note at the top of this file already says a statement names its profile and that an observation from another profile sits beside the 4.0.1 record. The table's own header contradicted that, so a row measured on another profile had nowhere to live except in place of the baseline. Also documents `captured only`, which the table already uses once and which a row with no independent read-back needs. STEERING.md needs no change: it already states the per-profile rule.
This was referenced Sep 9, 2026
jonathanstokes
marked this pull request as ready for review
September 9, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
## Operation coverageheader indocs/protocol.mdstill promised that every operation was exercised on firmwared14e, CorOS 4.0.1. That stopped being the rule when ADR-0020 landed.The note at the top of the same file already says a statement names its profile, and that an observation from another profile is written beside the 4.0.1 record and never in its place. The table's own header contradicted that. So a row measured on another profile had nowhere to live except in place of the baseline.
This came up on PR #47, where a contributor hit exactly that and rewrote the header to admit a CorOS 4.1.0 row. I asked them to revert it, because the header is mine to fix rather than theirs.
The change also documents
captured only, which the table already uses once and which a row with no independent read-back needs.docs/STEERING.mdneeds no change here: it already states the per-profile rule.Follow-up
Once #47 merges, the 4.0.1 chunk behaviour I measured for
create_local_backupgoes in beside its 4.1.0 row. On 4.0.1 a 130,178-character backup arrives as ONE message, so the 150,000 figure looks like a chunk ceiling rather than a fixed chunk size.Hardware
Docs-only, and the suite ran anyway on the final commit
c63f891, on Quad Cortex, CorOS 4.0.1 (app_fwd14e):Offline suite 2698 passed, 3 skipped.
mypyclean on 46 source files.One thing worth recording. An earlier run of this same commit failed two tests,
test_the_connect_burst_warms_the_cacheandtest_the_burst_delivered_every_entry_the_preset_surface_reads, with "the burst delivered nothing for preset".Those two check something the unit does about ten seconds after you connect: it sends its current state all at once, which preset is loaded, which scene is active, and so on. The model layer fills its cache from that. The tests check the cache really got filled, and this time it had not.
It is not this change. Both tests pass when re-run, both pass on unmodified
main, and this branch is 13 lines of Markdown, which cannot affect what the unit sends. So the unit is sometimes slow to send it. Written up in issue #57.