Repository navigation
docs: a pull request opens as a draft and the hardware suite runs before it is marked ready - #54
Merged
Merged
Conversation
…ore it is marked ready contributing.md gains "Before you mark a pull request ready": the suite runs on the final commit, its totals go in the description, a contributor with no unit says so and a maintainer runs it, and a maintainer may waive it for a change that cannot reach the wire. CLAUDE.md carries the same rule for the agent, with why: the 2026-09-07 post-merge run found two stale records a green offline suite had passed.
…ed as pytest prints it, and the rule's evidence is PR #53 Triage of the draft found: the template still carried the old optional-hardware rule; "totals line" named output only PR #53's branch prints; the two files disagreed on the no-unit state; nothing tied the run to a commit; the section's parent intro still said "if you want to"; the prerequisites lived elsewhere; "only evidence" overclaimed and dropped the manual read-back ask; and STEERING's pattern row still said hardware verification is manual via examples/.
…ed in the order pytest prints it, and the agent's rule asks for the CorOS version too
jonathanstokes
force-pushed
the
docs/pr-policy
branch
from
September 8, 2026 02:18
bc45ab8 to
7694941
Compare
jonathanstokes
marked this pull request as ready for review
September 8, 2026 02:19
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Writes down the pull request lifecycle this repo already follows in practice and has broken twice this week:
operations on ...block and pytest's last line.contributing.md gets "Before you mark a pull request ready" and the contribution flow says "draft". The PR template gets a Hardware section with the three states. CLAUDE.md gets the same rule for the agent, with the reason. STEERING's pattern row and section 10 stop saying hardware verification is manual, and its Change Log records this.
Docs only. No code changes. Rebased onto main after #53 merged (2026-09-08); #53 is the evidence this PR cites for the rule.
Triage
Full triage-pr pass on the draft (two reviewers): 9 findings, all fixed in 82a5c81 (the template still carried the old optional-hardware rule; "totals line" named output only #53 prints; the two files disagreed on the no-unit state; nothing tied the run to a commit; the parent intro still said "if you want to"; prerequisites were elsewhere; "only evidence" overclaimed; STEERING's pattern row was stale). Re-triage of that commit found 4 more, fixed in bc45ab8 (
--profileis for a unit the registry refuses, not "other than 4.0.1"; the report's two parts named in the order pytest prints them; the agent's rule dropped the CorOS version; the template's no-unit line did not say "mark ready anyway").Hardware
Waived by the maintainer. Stokes, 2026-09-07 evening, in the session that wrote this PR: "the unit isn't available this evening, but we can open PRs without the hardware run. I approve it." The change is docs only and cannot reach the wire.
For the record, the suite did run once on this branch, on its first commit f802350 (the code under test was main's before #53), CorOS 4.0.1:
The two failures were the two stale burst records that #53 corrected, and #53 is now in this branch's base. The unit dropped off USB before the later commits could be run, hence the waiver.