fix: batch discover prefilter equivalence + comma-generic selector round-trip (US-075, US-076)

[sting8k]

Two bounded fixes to the same class of defect: srcwalk emitted or accepted a query that its own parser then handled differently from the single-target path.

US-075 — batch discover dropped definitions (251a920, 83b5535)

discover 'a,b' --as symbol lost definitions the same terms find alone. Two defects in the batch prefilter:

1. Qualified terms: the Aho-Corasick gate scanned the raw literal (NextAction.new) while the single path scans the plain name (new).
2. find_iter is non-overlapping, so search masked search_batch.

Fix (11 lines): extract definition_scan_needle() from the single path and use it for batch; switch to find_overlapping_iter. Usage path, qualifier matching, ranking, Text OR untouched.

US-076 — emitted comma-generic selectors could not be replayed (ad9d334, 714fd0a, 4cc0825)

discover printed > Next: srcwalk show 'src/cache.rs:Cache<K, V>.get', but show/context/--section split target lists at every comma, so the copied command failed with Cache<K not resolved. Pre-existing on main.

Fix: one shared split_target_list() (src/format.rs) that splits only at depth-zero commas outside balanced <...>, wired into show, context, the show hint normaliser, section lists, and the artifact section guard. Markdown headings are resolved before framing so ## Compare A < B, C keeps working. Unbalanced <...> in a list fails once before any target executes. Generic parameters are kept in emission because Cache.get does not resolve and generics uniquely disambiguate overloads.

Discover/query batching, Text OR, intent routing, --skip-hubs, and other CSV/content parsers are untouched (25 comma sites inventoried: 9 changed, 2 inspected, 14 out of class).

Verification

• Regression tests fail on base, pass after each fix; oracles compare definition identity (path + anchor + kind), not counts.
• Byte parity on clean builds: US-075 12/12 single-query commands identical; US-076 24 commands / 72 stream files identical (including US-075 batch, Text OR, comma-path, heading controls).
• cargo test --locked 1498 pass / 0 fail / 1 ignored; clippy --locked -- -D warnings; fmt --check; build --release --locked.
• Perf (US-075, median of 9): plain batches unchanged; qualified batches 75→145ms / 142→203ms because more files are correctly admitted. Correctness costs work; not a speedup claim.
• Windows: tests/windows_paths.rs gains cfg(windows) cases for both stories — CI on this PR is the gate.

Docs

GUIDE.md drops the dotted-in-batch workaround and documents that commas inside emitted <...> are selector data; README examples; CHANGELOG Unreleased / Fixed. No version bump.

Deferred (pre-existing, separate story)

show '<path,with,comma>' --section X — the emitted form for comma paths — is rejected by the CLI multi-target branch even though the resolver accepts it. Identical on base and candidate; tracked separately.

[greptile-apps]

Greptile Summary

This PR restores equivalence between batched and single-symbol definition discovery and makes emitted generic selectors containing commas replayable across navigation commands.

• Shares qualified-definition scan-needle derivation between single and batch search and admits overlapping Aho-Corasick matches.
• Adds balanced-angle target-list framing across show, context, section reads, hints, and artifact handling.
• Adds cross-command, heading, generic-selector, batch-equivalence, and Windows regression coverage.
• Synchronizes release metadata and user/agent documentation for version 1.8.1.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
src/format.rs	Adds shared balanced-angle framing so commas nested in generic selectors remain part of one target.
src/cli_run.rs	Applies shared framing to show and context while preserving target-count and budget bounds.
src/read/section.rs	Uses shared framing for section lists while resolving exact Markdown headings before interpreting commas or angle characters.
src/artifact.rs	Allows generic selectors through the artifact single-section path while deferring lists and malformed framing to the shared reader.
src/search/symbol/batch.rs	Aligns batch definition admission with single-symbol search and reports overlapping or duplicate pattern hits independently.
src/search/symbol/definitions.rs	Extracts the qualified-query scan-needle rule for consistent reuse by single and batch definition searches.
tests/us075_batch_prefilter_equivalence.rs	Verifies batch discovery preserves the same definition identities as independent qualified and overlapping queries.
tests/us076_comma_selector_round_trip.rs	Verifies emitted comma-bearing generic selectors replay across affected navigation and section commands.
tests/windows_paths.rs	Extends Windows-specific coverage for qualified batch discovery and generic-selector replay.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CLI target or section input] --> B[Resolve exact Markdown heading when applicable]
    B -->|Resolved| C[Read one heading section]
    B -->|Not resolved or non-heading| D[Split at depth-zero commas]
    D --> E[One framed target]
    D --> F[Multiple framed targets]
    E --> G[Resolve generic selector unchanged]
    F --> H[Execute bounded target list]
    I[Batch symbol queries] --> J[Derive definition scan needle]
    J --> K[Overlapping Aho-Corasick prefilter]
    K --> L[Run structural matcher with original query]
    L --> M[Results equivalent to single-target search]

Loading

_{Reviews (3): Last reviewed commit: "release: 1.8.1" | Re-trigger Greptile}