Delete dead Utilities and Correlations subsystems#137
Merged
Conversation
The Utilities record was a thin wrapper around IRegister, exposed via IFunctionStore.Utilities and Workflow.Utilities. Neither the framework runtime nor any sample/test consumed it, so the record, IRegister, Register, IUnderlyingRegister, the per-store underlying registers, and their tests are dead. The store-level _register tables are no longer created or truncated.
# Conflicts: # Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/WatchDogsTests/CrashableFunctionStore.cs # Core/Cleipnir.ResilientFunctions/CoreRuntime/Invocation/Invoker.cs # Core/Cleipnir.ResilientFunctions/CoreRuntime/Invocation/Workflow.cs # Core/Cleipnir.ResilientFunctions/Storage/IFunctionStore.cs # Core/Cleipnir.ResilientFunctions/Storage/InMemoryFunctionStore.cs # Samples/Sample.ConsoleApp/Utils/CrashableFunctionStore.cs # Stores/MariaDB/Cleipnir.ResilientFunctions.MariaDB/MariaDbFunctionStore.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Utilities/Registersubsystem (IRegister,IUnderlyingRegister, in-memory + Postgres/MariaDB/SqlServer implementations, related tests).Correlations/ICorrelationStoresubsystem:Correlationsdomain class,ICorrelationStore+ in-memory/Postgres/MariaDB/SqlServer implementations,Workflow.RegisterCorrelation,Postman.RouteMessage,BaseRegistration.RouteMessage,ControlPanel.Correlations,InvocationHelper.CreateCorrelations, related test files and overrides.IFunctionStoreno longer exposesCorrelationStore;Postmannow takes onlyMessageWriters.Test plan
dotnet build Cleipnir.ResilientFunctions.sln— clean (0 warnings, 0 errors)dotnet test ./Core/Cleipnir.ResilientFunctions.Tests— 524 passed