ci(release): Isolate trusted npm publishing - #7
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
stickerdaniel
force-pushed
the
release/split-0.3.1
branch
from
September 27, 2026 13:39
d1c2adc to
574060c
Compare
stickerdaniel
marked this pull request as ready for review
September 27, 2026 14:36
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR substantially changes production release behavior by replacing tag-triggered publishing with main-branch/manual npm publication and introducing isolated OIDC credentials, artifact transfer, and release gating. Because it changes deployment infrastructure and performs an irreversible public package publication, human review is warranted. Notes:
You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tag releases install dependencies and run package code in the same job that holds npm's OIDC publishing permission. Version 0.3.0 also predates the ChatGPT.app 26.814 fix already on
main.Solution
I split the workflow into verification, a read-only release gate, and an isolated publish job. It publishes the tarball CI tested when a new version reaches
main. This PR bumps Browserjack to 0.3.1.Verification
I ran
npm ci,BROWSERJACK_RELEASE_GATE_TEST=required npm run verify(71 tests), both package smoke modes, a tarball publish dry run, and the gate on the real tarball. Mutations of the publish command, npm-view decision, and tar warning guard fail the new tests. Publishing awaits the npm Trusted Publisher configuration.Note
Isolate npm publishing behind a verified release gate in
release.ymlverifypackages and tests on macOS,release-gatevalidates the tarball's metadata, archive contents, and checksum, andpublishruns with only OIDC trusted-publishing permission and no source checkout or npm token.BROWSERJACK_ARTIFACT_DIRwhen set.Macroscope summarized 574060c.