(closes #506) Delete setuptools_scm_git_archive dependency#507
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
==========================================
- Coverage 92.23% 92.23% -0.01%
==========================================
Files 88 88
Lines 13861 13852 -9
==========================================
- Hits 12785 12776 -9
Misses 1076 1076 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@arporter I mark this PR ready for review, but this is the one I want to have a chat with you to understand what the previous implementation was trying to do. |
arporter
left a comment
There was a problem hiding this comment.
Thanks Sergi. It all looks OK to me - see my comments inline. We could chat about it tomorrow if you still have questions.
|
@arporter This is ready to review again, may questions may already be addressed by comments, they where why we needed the |
|
@arporter This is now ready again, I reverted to use "importlib" which seems the current recommended practice |
arporter
left a comment
There was a problem hiding this comment.
I think we've pretty much converged now. I suspect that at some point in the past we did show the version number in the docs but that has apparently been removed.
Just a bit more tidying and please could you update the version number in doxygen.config as that has been overlooked for a while.
|
@arporter Ready for another look, the docs built fine* with the proposed config changes. (*there are a few warnings but not related to this PR) |
arporter
left a comment
There was a problem hiding this comment.
All good now thanks. There's still an import of fparser in conf.py but I'll fix that.
No description provided.