Skip to content

(closes #506) Delete setuptools_scm_git_archive dependency#507

Merged
arporter merged 11 commits into
masterfrom
506_remove_scm_git_archive
Jun 4, 2026
Merged

(closes #506) Delete setuptools_scm_git_archive dependency#507
arporter merged 11 commits into
masterfrom
506_remove_scm_git_archive

Conversation

@sergisiso

Copy link
Copy Markdown
Collaborator

No description provided.

@sergisiso sergisiso self-assigned this May 26, 2026
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.23%. Comparing base (db683ef) to head (89d6710).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
- Coverage   92.23%   92.23%   -0.01%     
==========================================
  Files          88       88              
  Lines       13861    13852       -9     
==========================================
- Hits        12785    12776       -9     
  Misses       1076     1076              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter I mark this PR ready for review, but this is the one I want to have a chat with you to understand what the previous implementation was trying to do.

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sergi. It all looks OK to me - see my comments inline. We could chat about it tomorrow if you still have questions.

Comment thread pyproject.toml
Comment thread src/fparser/__init__.py Outdated
Comment thread src/fparser/__init__.py
Comment thread src/fparser/tests/test_issue8.py
@arporter arporter added reviewed with actions PR has been reviewed and is back with developer and removed ready for review labels Jun 1, 2026
@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter This is ready to review again, may questions may already be addressed by comments, they where why we needed the ...git_archive if we don't seem to be using .git_archival.txt anywhere, and if the changes with the _version method have any impact that I could not see.

@sergisiso sergisiso added ready for review and removed reviewed with actions PR has been reviewed and is back with developer labels Jun 1, 2026
@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter This is now ready again, I reverted to use "importlib" which seems the current recommended practice

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've pretty much converged now. I suspect that at some point in the past we did show the version number in the docs but that has apparently been removed.
Just a bit more tidying and please could you update the version number in doxygen.config as that has been overlooked for a while.

Comment thread src/fparser/__init__.py
Comment thread doc/source/conf.py Outdated
Comment thread doc/source/conf.py Outdated
Comment thread pyproject.toml
@arporter arporter added reviewed with actions PR has been reviewed and is back with developer and removed ready for review labels Jun 2, 2026
@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter Ready for another look, the docs built fine* with the proposed config changes.

(*there are a few warnings but not related to this PR)

@sergisiso sergisiso added ready for review and removed reviewed with actions PR has been reviewed and is back with developer labels Jun 2, 2026

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now thanks. There's still an import of fparser in conf.py but I'll fix that.

@arporter arporter added the ready for merge PR is waiting on final CI checks before being merged. label Jun 4, 2026
@arporter arporter merged commit 73e31b5 into master Jun 4, 2026
6 checks passed
@arporter arporter deleted the 506_remove_scm_git_archive branch June 4, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for merge PR is waiting on final CI checks before being merged. under review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants