Build against rodbus 1.5.0 and modernize CI actions#3
Merged
Conversation
Bump the rodbus checkout ref 1.4.0 -> 1.5.0 to produce a no-serial .NET build of the new release. Modernize the GitHub Actions, which were pinned to versions GitHub has since disabled (the v3 artifact actions no longer run): - actions/checkout v4 -> v6 - actions/upload-artifact v3 -> v6 - actions/download-artifact v2/v3 -> v7 - softprops/action-gh-release v1 -> v3 upload-artifact v4+ forbids multiple jobs writing the same artifact name, so the per-target FFI uploads now use unique names (ffi-modules-<target>) and the packaging job reassembles them with pattern + merge-multiple, matching the main rodbus CI. Also switch the bindings invocation from the short -o to --options to match the current rodbus-bindings CLI usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the no-serial .NET build to track the just-released rodbus 1.5.0, and modernizes the workflow, which was pinned to GitHub Actions that no longer run.
Changes
1.4.0→1.5.0(all three checkout steps) so we produce a no-serial build of the new release.actions/checkoutv4 → v6actions/upload-artifactv3 → v6actions/download-artifactv2/v3 → v7softprops/action-gh-releasev1 → v3upload-artifactv4+ forbids multiple jobs writing the same artifact name, so the FFI uploads now useffi-modules-<target>and the packaging job reassembles them withpattern: ffi-modules-*+merge-multiple: true— mirroring the main rodbus CI.-o→--optionsin therodbus-bindingsinvocation to match current CLI usage.Verified
--no-default-features --features tlsis valid forrodbus-ffiat the1.5.0tag (ring-based TLS, serial excluded).