prepare 1.7.0-RC1#408
Conversation
Summary of ChangesHello @jadamcrain, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a comprehensive update to transition the project to its Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prepares for the 1.7.0-RC1 release by updating version numbers across the project, including Cargo.toml files, pom.xml files, and documentation. It also includes a significant update of dependencies in Cargo.lock, which is expected for a release. The CHANGELOG.md has been updated to consolidate changes from previous milestones and add new ones for this release candidate. The changes are consistent and look good, with one minor suggestion for the changelog.
| * :star: Add optional support for parsing and transmission of zero-length octet strings via global setting. See [#379](https://github.com/stepfunc/dnp3/pull/379). | ||
| * :star: Add optional support for AWS libcrypto (aws-lc-rs) as TLS backend. See [#378](https://github.com/stepfunc/dnp3/pull/378). | ||
| * :star: Make OctetString constructor public in Java bindings. See [#402](https://github.com/stepfunc/dnp3/pull/402). | ||
| * :star: Make HeaderInfo constructor public for mockability in tests. See [#404](https://github.com/stepfunc/dnp3/pull/404). |
There was a problem hiding this comment.
The changelog for 1.7.0-M2 included a bug fix: * :bug: Fix Maven Central deployment issues for post-OSSRH era.. It seems to have been omitted from the 1.7.0-RC1 changelog. Was this intentional? If not, it would be good to include it for completeness.
| * :star: Make HeaderInfo constructor public for mockability in tests. See [#404](https://github.com/stepfunc/dnp3/pull/404). | |
| * :star: Make HeaderInfo constructor public for mockability in tests. See [#404](https://github.com/stepfunc/dnp3/pull/404). | |
| * :bug: Fix Maven Central deployment issues for post-OSSRH era. |
No description provided.