Add per-connection master address override for outstation clients#406
Conversation
Summary of ChangesHello @jadamcrain, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement for DNP3 outstation clients, allowing them to dynamically override the master address on a per-connection basis. This feature is crucial for robust failover mechanisms, enabling outstations to connect to different masters at various endpoints. The changes involve updates to the core API, FFI bindings, and example code to facilitate this new capability, alongside minor code quality improvements and .NET target updates. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature for outstation clients, allowing per-connection master address overrides, which is particularly useful for failover scenarios. The implementation is well-structured, propagating the new master_address setting from the ConnectionInfo builder down to the outstation session. The refactoring of the FFI connection handler to a builder pattern is a significant improvement, making the API more extensible and idiomatic, although it introduces breaking changes for FFI consumers. The accompanying updates to examples, especially the C++ outstation example, clearly demonstrate the new functionality. The code quality improvements, such as using #[derive(Default)], are also welcome. I have one suggestion to improve the robustness of the session handling.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
ConnectionInfo::set_master_address()to allow outstations to use different master addressesper connection
endpoints
Changes
set_master_address()toConnectionInfobuilder(dnp3/src/tcp/connector.rs:102-112)
ConnectionInfobuilder pattern with masteraddress support
master addresses
Defaultimplementations with#[derive(Default)]for decode/attrenums