Skip to content

Make the HeaderInfo constructor public for mockability in tests #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jadamcrain merged 1 commit into from
Oct 3, 2025
Merged

Make the HeaderInfo constructor public for mockability in tests #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ffi/dnp3-schema/src/master/read_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ pub(crate) fn define(
)?
.doc("Information about the object header and specific variation")?
.end_fields()?
.add_full_initializer("init")?

@gemini-code-assist gemini-code-assist Bot Oct 3, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding a full initializer to the header_info struct enhances its usability and testability. This is a good change to improve the API.
Consider adding documentation to the initializer to explain its purpose and usage.

Suggested change
.add_full_initializer("init")?
.add_full_initializer("init")? // Add a full initializer for easy object construction

.build()?;

let read_type = define_read_type_enum(lib)?;
Expand Down