Release 2.5.1: avoid starting containers when configuring Composer cache - #256
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe composer-cache command saves settings without starting stopped services. If PHP services are running, it can recreate only those services to apply the cache mount. The CLI version and changelog are updated to 2.5.1. ChangesComposer cache settings
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Composer-cache change is ready to merge after normal checks; no concrete issue remains from the reviewed changes. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Release testing
This prepares
2.5.1for testing againstrelease/2.5.1. The CLI version is bumped to2.5.1, and the release date remains TBD while we validate consuming projects.Main Changes
slic composer-cache setpreviously offered to restart the PHP services and defaulted to yes in noninteractive mode. On a fresh CI runner, that could start the stack beforeslic useselected the project's PHP version. Applying that version afterward could require additional image downloads and container recreation.The cache command now saves the setting and checks which PHP services are running:
slic,wordpress, or both are running, it offers to recreate only those services with the updated cache mount.--no-deps, leaving stopped services and dependencies alone. Compose failures are reported and return a nonzero exit status.This applies to both
composer-cache setandunset.CI setup
Configure the cache and stage the desired PHP version before selecting the project:
The first two commands configure the next startup without starting containers.
slic usethen applies the selected PHP version. Projects can also declare their PHP version inslic.jsonor.env.slic.localinstead of staging a matrix version explicitly.This fixes premature startup from the cache command. It does not change how
slic usehandles mount and PHP changes on an already-running stack.Testing
setandunsetwith no PHP services running, either service running individually, and both running.git diff --checkpassed.The behavior checks stubbed container operations; consuming-project CI validation remains outstanding. Temporary test files are not included in this PR.
Summary by CodeRabbit