13B. Pin that a boot past the barrier wires nothing - #75
Open
nikolaystrikhar wants to merge 1 commit into
Open
Conversation
nikolaystrikhar
force-pushed
the
57-scheduler-fallback-pinned
branch
from
August 24, 2026 13:41
3c883d3 to
531bf9b
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
SchedulerTestpins that aboot()past the barrier runs the sequence inline and wires nothing onplugins_loaded.Usage:
Why this way:
Deleting the
returnused to leave the suite green. The inline branch defines the guard constant, so the step it then wired found the sub-plugin already loaded and skipped quietly — the wiring that should never have happened had no symptom left to assert on.The probe is proved before it is trusted. A counter reading the wrong hook name reports "nothing wired" and passes for the wrong reason, so the test resets, boots inside the window, and asserts the same count rises.