Skip to content

13B. Pin that a boot past the barrier wires nothing - #75

Open
nikolaystrikhar wants to merge 1 commit into
52-registration-after-the-passfrom
57-scheduler-fallback-pinned
Open

13B. Pin that a boot past the barrier wires nothing#75
nikolaystrikhar wants to merge 1 commit into
52-registration-after-the-passfrom
57-scheduler-fallback-pinned

Conversation

@nikolaystrikhar

Copy link
Copy Markdown
Contributor

What: SchedulerTest pins that a boot() past the barrier runs the sequence inline and wires nothing on plugins_loaded.

Usage:

$before = $this->callbacks_at( 'plugins_loaded' );   // every priority
Absorber::boot();                                    // past the barrier
$this->assertTrue( defined( self::GUARD ) );         // the inline branch ran
$this->assertSame( $before, $this->callbacks_at( 'plugins_loaded' ) );

Why this way:

Deleting the return used to leave the suite green. The inline branch defines the guard constant, so the step it then wired found the sub-plugin already loaded and skipped quietly — the wiring that should never have happened had no symptom left to assert on.

The probe is proved before it is trusted. A counter reading the wrong hook name reports "nothing wired" and passes for the wrong reason, so the test resets, boots inside the window, and asserts the same count rises.

@nikolaystrikhar
nikolaystrikhar force-pushed the 57-scheduler-fallback-pinned branch from 3c883d3 to 531bf9b Compare August 24, 2026 13:41
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Enterprise

Run ID: bea2f645-09c4-4125-8514-310b6dfb16f7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant