12. Hand a host the policy list its settings control has to offer - #73
Open
nikolaystrikhar wants to merge 1 commit into
Open
12. Hand a host the policy list its settings control has to offer#73nikolaystrikhar wants to merge 1 commit into
nikolaystrikhar wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Conflict_Policy::all()becomes public API, so a host's settings control can list every policy instead of hardcoding the three constants.Usage:
Why this way:
Our own recipe asked for a list we kept private. Staged absorption tells hosts to move the policy behind an option; the screen that writes it had to spell the three constants out, and a fourth policy would miss every such screen silently.
Bare strings, no labels. This library has no opinion on toggle UI, and a label produced here would be in the wrong textdomain — the host words its own, keyed off the strings we hand it.