11. Give every assertion something it can fail on - #72
Open
nikolaystrikhar wants to merge 2 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: closes the assertions in the notice-store, writer, provider and redirector suites that pass whether or not the behaviour they name still exists, and re-arms WordPress's unexpected-
_doing_it_wrong()check thatWithIncorrectUsagewas giving away.Usage:
composer test:unitnow runs the singlesite leg and then the multisite one, which is wheredeactivate_plugins(),manage_network_pluginsand the site-option queue actually differ.Why this way:
An absence needs a control.
assertNotContains( $option, wp_load_alloptions() )passes over an empty bundle and goes on passing for ever, so both queue tests now find an option written with autoload on first, out of a bundle re-read from the database.The
\zanchor is unreachable through an ordinary request URI, so the parse is stubbed. PHP'sparse_url()rewrites a path's control bytes to_, which refusesedit.php\nfor a different reason and hides the anchor entirely; that is a parser detail, not a promise, and\zis what holds if it changes.The expectation is what the caller declared, not whatever arrived. Registering every report as expected disarmed WPTestCase on the first one a test wanted, so only this library's own reports are registered now.