10B. Pin what a container set after boot really does (just tests) - #71
Open
nikolaystrikhar wants to merge 1 commit into
Open
10B. Pin what a container set after boot really does (just tests)#71nikolaystrikhar wants to merge 1 commit into
nikolaystrikhar wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
nikolaystrikhar
force-pushed
the
59-container-set-after-boot
branch
from
August 24, 2026 13:41
285f889 to
849b544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: tests for
Absorber::boot(), the collaborator accessors and theplugins_loadedsteps whenConfig::set_container()is called after boot.Usage: none — the behaviour is unchanged. What changes is that the warning on
boot()is now a behaviour the suite holds: the hooks keep the container boot closed over, the accessors answer for the replacement, and a secondboot()binds nothing into it.Why this way:
A warning only a docblock makes is a warning nothing enforces. Two live containers is the failure mode a host hits by wiring
set_container()from a service provider, and until now the suite would have stayed green through any change to which half resolves from where.Asserted by loading a sub-plugin and reading
Absorber::all(), not by counting resolutions. The damage is not that two containers exist — it is that the load pass works while the registry a host can reach reports nothing, with no report in between, which is exactly what a host would go debugging.