10A. Make the registrar accessor agree with all() - #70
Open
nikolaystrikhar wants to merge 2 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Eight of its members are public static -- they are the API a host calls. What no subclass can reach is the booted flag and the collaborator helper, and what makes an override pointless is that every internal call is self::.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Absorber::registrar()drains the registration buffer throughRegistry\Readerbefore handing the registrar back, so it agrees withAbsorber::all().Usage:
Absorber::registrar()->all()now answers with every registration made so far, from a host bootstrap at plugin-file scope, not only afterplugins_loadedpriority 5.Why this way:
A public accessor that disagrees with another is worse than no accessor. Registration is buffered until something reads it, so the registrar was empty for the whole window a host actually asks in — while
Registrar_Interface::all()promises every registration, in order, andAbsorber::all()delivered it. Documenting the drift would have left two right answers to one question.The drain runs after the binding is checked, not before.
Registry\Readertakes a registrar as a constructor argument, so a registrar bound to the wrong class is an unbuildable reader too: draining first would send the host after a collaborator it never bound instead of naming the binding it got wrong.