9B. Prove the recorder that pins the guard check ahead of the dependency check

[nikolaystrikhar]

What: LoaderTest::test_an_already_loaded_sub_plugin_is_not_dependency_checked proves its recorder before trusting it.

Usage:

$this->assertSame( 0, $checked );

$check();

$this->assertSame( 1, $checked, 'The recorder must catch a call that really happened.' );

Why this way:

A "did not happen" assertion needs a live recorder. assertSame( 0, $checked ) passed equally for a mistyped config key, a fixture trait that dropped the override, or a load path that stopped reading dependency_check at all. Twelve other sites in this suite already invoke the recorder once afterwards; this one did not.

It is the only test pinning the gate order. That the guard constant is checked ahead of the dependency check is what carries the re-declaration guarantee and keeps a plugin the admin can watch working from raising a requirements notice.

The shape is the suite's, not a new one. Hoisting the closure into $check and calling it once matches test_a_skipped_load_runs_no_activation_callback exactly.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Enterprise

Run ID: 370f5797-93a8-4485-8ce8-9d0d8738c897

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}