7B. Report a host basename no installed plugin answers to - #65
Open
nikolaystrikhar wants to merge 1 commit into
Open
7B. Report a host basename no installed plugin answers to#65nikolaystrikhar wants to merge 1 commit into
nikolaystrikhar wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
nikolaystrikhar
force-pushed
the
54-host-basename-validated
branch
from
August 24, 2026 13:41
b4f04cf to
e53b1e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Conflict\Detector::deactivation_would_strand_sites()reports through_doing_it_wrong()and theerroraction whenConfig::set_host_plugin_basename()names no installed plugin.Usage:
Why this way:
The check belongs at the point of use, not in the setter.
set_host_plugin_basename()is static and a host calls it at plugin-file scope, whereget_plugins()does not exist. The detector asks on the request where the value is about to decide whether a standalone is deactivated.The answer is not changed, only reported. A typo, an mu-plugin host or a symlinked directory all answer "not network-active" for ever, which is indistinguishable from the guard working — but a name we cannot resolve is not consent to pull a plugin from every site on a network. An unset basename stands the guard down exactly as before.
Once per request, on the instance. The detector is a singleton, so one report and one
get_plugins()per request. A static flag would go quiet for the rest of the worker's life and would need a reset seam insrc/.