7A. Stand the conflict pass down when the load gate says no - #64
Open
nikolaystrikhar wants to merge 2 commits into
Open
7A. Stand the conflict pass down when the load gate says no#64nikolaystrikhar wants to merge 2 commits into
nikolaystrikhar wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
The container clause outlived the registry refactor: a reader holds its own registrar, so a container that cannot supply one fails while the pass is built. What can still throw is the hook name the load gate is read under. "Both methods" predates the stranding guard, which made three.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Conflict\Detector::is_in_conflict()applies{prefix}/plugin_absorber/should_load, so the conflict pass atplugins_loadedpriority 5 sees the gate the load pass reads at 6.Usage:
Why this way:
A veto used to cost the site the feature outright. Under the default policy the standalone was deactivated, the merge notice said the bundled copy had taken over, the request redirected — and priority 6 then required nothing.
docs/filters.mdsteers hosts straight into it: a per-slugreturn falseis its only worked example.The filter goes last. It is host code, so the sub-plugin must be enabled, name a standalone, and have that standalone running before any of it executes — which is also where the load pass asks it, and it keeps the filter off every request that has no conflict.
No new catch.
Boot\Schedulerwraps the step incatch ( Throwable )andConflict\Resolvercatches per sub-plugin, so a filter that throws is already reported and already survivable.