2. State the methods every rebindable seam must implement (docs only) - #55
Conversation
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe extension guide now defines implementation contracts for replaceable seams, multisite behavior, boot-time container binding, and configuration error handling. ChangesExtension contracts and boot behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This documentation-only change introduces no runtime or production behavior changes, so no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What: adds a "What each seam must implement" section to
docs/extending.mdcarrying the signatures and contract for all six rebindable interfaces, and corrects what the same file says aboutAbsorber::all()and about container failures.Usage:
Why this way:
A doc that tells a host to rebind a seam has to name the seam's methods. It recommended rebinding
Checker_Interfacewhile listing neither of its two, and an omission there is a fatal at class-declaration time for anyone who followed the advice without openingsrc/.Signatures alone would not be enough, so each method carries its contract. That
is_network_active()must befalseoff multisite because callers skip their ownis_multisite()guard, that the activation record is written after the callback returns — what a plausible implementation gets wrong silently.Summary by CodeRabbit