Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This was referenced Jun 23, 2026
doc.go: add the Storage group (process.go, hotsource.go) to the file map and switch the map header to 'by concern' now that the package spans two layers; shrink the 'Later layers' note accordingly. golangci-lint (this layer's own new findings): - hotchunk.DB.MaxCommittedSeq: drop named returns (nonamedreturns) - process.go / ingest driver.go: wrap two >120-char lines (lll)
doc.go: add Planner (resolve/execute/eligibility), Ingestion (ingest), Orchestration (progress/lifecycle/retention), and Observability groups; update the coverage line and 'Later layers' note. golangci-lint (this layer's own new findings): - misspell: cancelled -> canceled (comments across ingest/lifecycle + their tests) - modernize: if-guard -> max() in IngestionLag and lastCommittedLedger - staticcheck QF1008: cfg.ExecConfig.WithDefaults() -> cfg.WithDefaults() - revive: rename unused refineWithHotDB(cat) parameter to _ - errname: assertErr/errStr -> errSyntheticOp/stringError (test) - lll: wrap/shorten 4 long lines - godoclint: Metrics doc starts with the symbol name - drop two dead //nolint:gosec directives; //nolint:gosec on uint32(floor) (now needed after the max() rewrite) - //nolint for forward-/test-only or inherently-complex symbols: runIngestionLoop metrics (unparam), seqWithinRetention (unused), Metrics (interfacebloat), runLifecycleTick (gocognit/gocyclo/cyclop/ funlen), the plan-and-execute guard (nestif)
This was referenced Jun 24, 2026
Contributor
Author
|
Superseded by a new 2-phase stacked series that re-slices this work by phase (backfill → live ingestion + lifecycle), with the MVP scope cuts (recovery / audit / convergence / retention-reconfiguration dropped) and the folded-in fixes (cold+hot ingest service +
Each layer builds + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 1, Layer 3 of 4 — Orchestration. Stacked on Layer 2 (storage). Diff is the orchestration brain.
Driving production:
Compiles +
-short-green on Layers 1–2.