Skip to content

Fix preview basePath to match pr-preview-action deploy path #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaankacar merged 1 commit into from
May 25, 2026
Merged

Fix preview basePath to match pr-preview-action deploy path #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/preview-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,13 @@ jobs:
uses: actions/checkout@v4

# Preview-scoped basePath. The site is served from skills.stellar.org
# at the apex, so previews live at `skills.stellar.org/pr/<N>/`.
# at the apex, so previews live at `skills.stellar.org/pr/pr-<N>/`.
# `rossjrw/pr-preview-action` deploys under `<umbrella-dir>/pr-<N>`
# by default, so the basePath must include the `pr-` prefix on the
# number to match — otherwise asset URLs baked into the HTML 404.
- name: Resolve NEXT_BASE_PATH
if: github.event.action != 'closed'
run: echo "NEXT_BASE_PATH=/pr/${{ github.event.number }}" >> "$GITHUB_ENV"
run: echo "NEXT_BASE_PATH=/pr/pr-${{ github.event.number }}" >> "$GITHUB_ENV"

- if: github.event.action != 'closed'
uses: pnpm/action-setup@v4
Expand Down
Loading