Cover signing with raw secret seed#975
Open
chrisx9z wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds coverage for signing using a Keypair’s raw secret material and updates Keypair docs to clarify what rawSecretKey() returns.
Changes:
- Added a unit test that signs using
keypair.rawSecretKey()and verifies the signature withrawPublicKey(). - Updated
Keypair#rawSecretKeyJSDoc to describe the returned bytes as a 32-byte seed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/unit/signing_test.js | Adds a test for signing with a Keypair’s raw secret bytes and verifying the result. |
| src/keypair.js | Updates docstring for rawSecretKey() return value/meaning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+194
to
197
| * Returns the raw 32-byte secret seed. | ||
| * @returns {Buffer} | ||
| */ | ||
| rawSecretKey() { |
Comment on lines
+34
to
+37
| it('can sign with a Keypair raw secret seed', function () { | ||
| let data = Buffer.from('hello world', 'utf8'); | ||
| let keypair = StellarBase.Keypair.fromRawEd25519Seed(seed); | ||
| let actualSig = StellarBase.sign(data, keypair.rawSecretKey()); |
Comment: Adds a regression test for signing with Keypair.rawSecretKey and documents that it returns the raw seed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #281.
Verification