Accept 32-byte claimable balance StrKeys

[chrisx9z]

Summary

• accept standard 56-character / 32-byte claimable balance B-addresses in StrKey validation
• keep existing 58-character / 33-byte v0 claimable balance validation for compatibility
• reject 33-byte claimable balance payloads with a non-v0 discriminant
• add focused StrKey tests for both accepted forms and the invalid discriminant case

Fixes #965.

Verification

• node --check src/strkey.js
• node --check test/unit/strkey_test.js
• corepack yarn mocha test/unit/strkey_test.js --grep claimableBalances --require @babel/register --require ./test/test-helper.js
• corepack yarn mocha test/unit/strkey_test.js --require @babel/register --require ./test/test-helper.js
• corepack yarn eslint -c ./config/.eslintrc.js src/strkey.js
• git diff --check

Note: linting the whole legacy strkey_test.js file reports pre-existing style violations, so the source lint check was scoped to src/strkey.js while the full strkey test file was verified with mocha.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds support for claimable balance StrKeys that omit the discriminant byte while tightening validation for discriminant-bearing payloads.

Changes:

• Accept claimable balance StrKeys encoding either 32-byte payloads (no discriminant) or 33-byte payloads (v0 discriminant only).
• Add unit coverage for 32-byte claimable balance StrKeys and rejection of non-v0 discriminants.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
test/unit/strkey_test.js	Adds tests for 32-byte claimable balance StrKeys and invalid non-v0 discriminant cases.
src/strkey.js	Updates isValid logic for claimable balance StrKeys to accept 56/58-char encodings and enforce v0 discriminant semantics.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2823285cdd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Preserve the v0 discriminant for Address conversion

When a standard 56-character claimable-balance StrKey is now accepted here, new Address(bAddress) stores only the 32-byte hash returned by decodeClaimableBalance; later Address.toScAddress() treats this._key.at(0) as the claimable-balance discriminant and subarray(1) as the payload. For any code that parses one of these newly-valid B-addresses and converts it to an ScAddress, the first hash byte is used as the enum value instead of v0, so conversion throws or builds the wrong XDR. The newly accepted 32-byte form needs to be normalized to the existing v0+hash representation before Address uses it.

Useful? React with 👍 / 👎.