Source Verification RFP Submission#9
Conversation
chadoh
force-pushed
the
feat/rfps-source-verification
branch
from
694512b to
881292f
Compare
chadoh
force-pushed
the
feat/rfps-source-verification
branch
from
881292f to
05b7dac
Compare
elizabethengelman
left a comment
elizabethengelman
left a comment
There was a problem hiding this comment.
Just adding a few thoughts as I'm reviewing for the first time!
| > - https://github.com/FrankSzendzielarz/SorobanRPCSDK | ||
| > => Good one - https://drive.google.com/file/d/167c6KVuyvRo7haInUahDfeMRxkO8gya3/view" | ||
|
|
||
| ## Verifier added to Registry's allowlist |
There was a problem hiding this comment.
I like the balance of these diagrams which are more focused on finer grain details vs the ones in #11 which give a good overview of the system as a whole. I think that both are important & helpful to the reviewer.
I'll continue noodling on it, and see if I can come up with any other questions that another finer-grain diagram could help answer.
There was a problem hiding this comment.
I think I like the idea of the finer-grain diagrams to explain seams in the system. One idea that comes to mind: a diagram that shows how verification run triggers work, specifically for back-verification.
`rfps/source-verification` is now a directory with: - README.md: the copy-pasted source of the RFP document itself - full-application.md: our work-in-progress responses for the full form submission - technical-architecture-highlevel.md: copy-pasted from #11 Co-authored-by: Ethan Frey <ethanfrey@noreply.github.com>
chadoh
force-pushed
the
feat/rfps-source-verification
branch
from
d29854e to
d2f2639
Compare
|
Thanks @elizabethengelman! Glad you commented on those original diagrams so we can find them as we finalize the design in Milestone 1. I think for the RFP application it's fine (preferred, even) to have it be a little more high-level. Closing this in favor of the equivalent PR in the new RFP repo (stellar-registry/rfps#1) — we have a |
3 participants
The Aha Company's submission for https://stellar.gitbook.io/scf-handbook/scf-awards/build-award/rfp-track#contract-source-verification-service