Repository navigation
Conversation
Migrate the `stats/incr/mprod` test suite from relative tolerance
assertions to ULP difference assertions using
`@stdlib/assert/is-almost-same-value`.
Both converted assertions ("overflow may be transient" and "underflow
may be transient") were tightened to a measured minimum of 1 ULP.
Ref: #11352
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwDVaAXqBZH6YKryzyaJaN
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: skipped
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
stdlib-bot
added
Statistics
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/mprodtest suite from relative tolerance testing to ULP difference testing, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.Specifically, this pull request:
@stdlib/assert/is-almost-same-valueimport and removes the now-unused@stdlib/constants/float64/epsand@stdlib/math/base/special/absimports.delta/tolcomputations in theoverflow may be transientandunderflow may be transienttest cases, replacing them with anactualvariable.t.strictEqual( delta <= tol, ... )assertions witht.strictEqual( isAlmostSameValue( actual, expected, 1 ), true, 'returns expected value' );.Only
test/test.jsis modified; the package has notest/test.native.js. No other test cases were touched, and existing exact comparisons (t.strictEqual/t.deepEqual) were left as-is.ULP bounds
Both converted assertions use a ULP constant of
1, which is the measured minimum:overflow may be transientunderflow may be transientThe bound was tightened agentically, starting high and lowering: the suite passes at
64,2, and1, and fails at0with exactly the two converted assertions failing, confirming1is the minimum required value. The full suite (500 assertions) was run twice at the final bound with identical results, confirming determinism.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
stats/incr/nanmprodmigration, which covers the same two transient overflow/underflow test cases for the NaN-aware variant of this accumulator.make test TESTS_FILTER=".*/stats/incr/mprod/.*"passes 500/500 (run twice).lint-editorconfig-filestarget could not be run in this environment because it downloads theeditorconfig-checkerbinary from a GitHub repository that was not reachable from the sandbox (HTTP 403). The file was instead verified manually against.editorconfig: LF line endings, UTF-8, tab indentation, no trailing whitespace, and a final newline.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. It selected the package, studied the already-merged
stats/incr/nanmprodmigration as prior art, performed the test conversion, and determined the minimum ULP bound empirically by probing the suite at decreasing values ofN.@stdlib-js/reviewers
Generated by Claude Code