Repository navigation
Conversation
Migrate the tests for `stats/incr/nanmmeanstdev` from relative tolerance testing to ULP difference testing by replacing the computed `delta`/`tol` comparison with `@stdlib/assert/is-almost-same-value`. The ULP bound is `0`, which is the measured minimum: the accumulated moving corrected sample standard deviation is bit-for-bit equal to the expected value. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013YxL644SUL6UDUhBovNN5d
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/nanmmeanstdevfrom relative tolerance testing to ULP difference testing, replacing the computeddelta/tolcomparison withisAlmostSameValue.0for the converted assertion, which is the measured minimum: the accumulated moving corrected sample standard deviation is bit-for-bit equal to the expected value, so no non-zero ULP budget is required. Starting from a bound of64and tightening,0is the smallest integer for which the full fixture set passes, and the suite was run twice at0to confirm determinism.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires from the test file.Only
test/test.jsis modified; the package has notest/test.native.js. Existing exact comparisons (e.g., thet.deepEqualfixture checks, thet.strictEqualmean check, and the NaN/nullchecks) are left untouched.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
0(measured minimum). The ULP distance was measured directly via@stdlib/number/float64/base/ulp-difference: the returned mean is0ULP from5.0and the returned corrected sample standard deviation is0ULP fromsqrt( 19.0 ).make test TESTS_FILTER=".*/stats/incr/nanmmeanstdev/.*"is green on two consecutive runs, 448/448 assertions passing.make lint-javascript-tests TESTS_FILTER=".*/stats/incr/nanmmeanstdev/.*"is clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task: it selected the package, performed the test migration, measured the minimum ULP bound, and ran the tests and linter.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_013YxL644SUL6UDUhBovNN5d
Generated by Claude Code