Repository navigation
docs: fix incomplete example and missing @private tag in _tools/remark/plugins - #15957
Draft
Planeshifter wants to merge 2 commits into
Draft
Planeshifter wants to merge 2 commits into
Planeshifter wants to merge 2 commits into
Conversation
…n-structure` example Added the missing `remark().use( lint ).process( str, done )` call to the module-level JSDoc example in `lib/index.js`. The example previously defined `str` and `done` without ever running the plugin. Invoking `remark().use( <plugin> )` in the module example is present in 93% of `_tools/remark/plugins` siblings (13/14). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RNGgXLihP99pK9yerPgKRr
…-equations-to-file` Added the missing `@private` JSDoc tag to the internal `onWrite` callback in `lib/transformer.js`. Tagging every non-exported function `@private` is followed by 93% of `_tools/remark/plugins` siblings (13/14) and by every other internal function in the same file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RNGgXLihP99pK9yerPgKRr
_tools/remark/plugins/remark-lint-html-section-structure and _tools/remark/plugins/remark-svg-equations-to-file@private tag in _tools/remark/plugins
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
@stdlib/_tools/remark/pluginspackages into line with JSDoc conventions that the rest of the namespace follows (≥93% conformance). The changes are documentation-only and do not alter behavior.Namespace summary
@stdlib/_tools/remark/plugins, 14 members, none autogenerated. Majority threshold: ≥11/14 (75%).package.jsonkey sets and values; README##/###heading order and<section>classes; test/benchmark/example filenames; and, per package, the public signature, return kind, validation prologue, error construction, JSDoc shape (exported and internal functions),@stdlib/*dependencies, and the module-level@example.README.md,package.json,lib/index.js,examples/index.js),package.jsontop-level keys, README heading order (Usage→ [Notes] →Examples), andformat-based construction for every thrownError/TypeError(12/12 packages that construct errors).@exampleinvokesremark().use( <plugin> )(13/14); every internal function JSDoc carries@private(13/14).engines.node(>=0.10.0vs>=6.0.0, 8/6),directories.test(4/14),test/presence (4/14), themdastkeyword (9/14), presence of an options argument (10/14), theisObjectoptions check (9/14), and@exampleon the exported function (4/14).@stdlib/_tools/remark/plugins/remark-lint-html-section-structureThe module-level JSDoc
@exampleinlib/index.jsdeclaredstranddonebut never ran the plugin. Addedremark().use( lint ).process( str, done );, matchingremark-lint-equations. 13 of 14 sibling plugins (93%) invokeremark().use( <plugin> )in the module example. Doc-only; no behavior change.@stdlib/_tools/remark/plugins/remark-svg-equations-to-fileAdded the missing
@privateJSDoc tag to the internalonWritecallback inlib/transformer.js. Every other internal function in the file (transformer,visitor,onDir,next,onSVG,done) already carries the tag, and tagging every non-exported function@privateis the convention in 13 of 14 namespace packages (93%). This also satisfies thestdlib/jsdoc-private-annotationlint rule. Doc-only; no behavior change.Related Issues
No.
Questions
No.
Other
Validation
lib/*.jsfile.confirmed-driftfor both corrections. No test, example, or tooling reads either JSDoc block. The only external consumers (etc/remark/plugins/lint-html-section-structure,tools/make/lib/markdown/equations.mk) reference the package path, not the JSDoc. The new example line adds norequire(, sostdlib/jsdoc-main-exportstill sees the self-require last, and it carries no// returnsannotation forstdlib/jsdoc-doctestto check. No structural candidates reached review, so the structural-review pass had nothing to check.node --checkpasses on both files. ESLint was not run (dependencies not installed in the authoring environment).Deliberately excluded
remark-lint-expected-html-sectionsmodule example (var linter = remark().use( ... )without.process): valid and minimal; judged an intentional deviation.relatedREADME section inremark-lint-expected-html-sectionsandremark-lint-html-section-structure(12/14): generator-owned section.remark-lint-equations,remark-lint-html-section-structure, andremark-lint-expected-html-sections: these arefile.messagereports, notErrorconstruction.remark-run-javascript-examples/lib/index.js: already touched by open PR chore: fix JavaScript lint errors (issue #10073) #15313.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by an automated cross-package API drift sweep run by Claude Code against
@stdlib/_tools/remark/plugins. Features were extracted per package, majorities were computed at a 75% threshold, and each surviving candidate was validated by independent review passes before any edit. Both changes are mechanical JSDoc edits (3 added lines across 2 files).@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01RNGgXLihP99pK9yerPgKRr
Generated by Claude Code