test: migrate simulate/iter/periodic-sinc to ULP-based assertions - #15819
Merged
Merged
Conversation
Replace the relative tolerance assertions in the `simulate/iter/periodic-sinc` tests with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. All seventeen fixture loops are exact (0 ULP), as measured over the full fixture set. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R9yT3mZZw8YXi2JDjpZKth --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
simulate/iter/periodic-sincfrom relative tolerance assertions to ULP difference assertions, as proposed in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolcomparison idiom in all seventeen fixture loops oftest/test.jswitht.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, 0 ), true, 'returns expected value' );.@stdlib/assert/is-almost-same-valuerequire and removes the now-unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires, along with the now-unuseddeltaandtollocal declarations.ULP bounds
The package has one ULP constant, used in all seventeen fixture loops:
test/test.js1.0 * EPS * abs( expected )The bound was measured, not guessed. Each of the 4319 value comparisons across the full fixture set was instrumented to compute the smallest
maxULPfor whichisAlmostSameValuereturnstrue; the measured maximum was0for every loop, i.e. the returned values are bit-for-bit identical to the expected values.0is therefore both the measured minimum and the tightest representable bound, and it matches the bound already used by the converted sibling packagesimulate/iter/hann-pulse.This is expected here: the test's expected values are computed from the same deterministic
@stdlib/math/base/special/sinpiand@stdlib/math/base/special/wrapprimitives as the implementation, with no PRNG-generated fixtures, so the comparison is reproducible across runs and platforms. The suite was run twice at the final bound, with 8539 of 8539 assertions passing both times and no variation between runs.Only
test/test.jsis changed; there is notest/test.native.jsfor this package, andtest/test.validate.jscontains no tolerance-based assertions.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification performed locally:
make test TESTS_FILTER=".*/simulate/iter/periodic-sinc/.*"→ 8539 passing, 0 failing (run twice, identical results).make lint-javascript-files FILES="lib/node_modules/@stdlib/simulate/iter/periodic-sinc/test/test.js" ESLINT_CONF="etc/eslint/.eslintrc.tests.js"→ 0 errors (one pre-existing@cspell/spellcheckerwarning for the word "sinc", present before this change).make lint-editorconfig-filescould not run in this environment:editorconfig-checkerdownloads its binary from theeditorconfig-checker/editorconfig-checkerGitHub releases, which was unreachable here.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. Claude Code selected the package, studied the already-converted sibling packages in the same family to mirror the established idiom, applied the mechanical test conversion, measured the minimum ULP bound by instrumenting the fixture comparisons, and ran the tests and linters. It is opened as a draft for human review.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01R9yT3mZZw8YXi2JDjpZKth
Generated by Claude Code