Skip to content

fix(repl): fix multiline editing and completer navigation with keybindings - #15817

Open
notstanzinn wants to merge 2 commits into
stdlib-js:developfrom
notstanzinn:fix/repl-multiline-keybindings
Open

notstanzinn wants to merge 2 commits into
stdlib-js:developfrom
notstanzinn:fix/repl-multiline-keybindings

Conversation

@notstanzinn

Copy link
Copy Markdown

…dings

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes multiline line boundary editing (deleteLeft, moveLeft, moveRight) in the REPL. When keybindings were merged, editor actions intercepted backspace and arrow keys without delegating to MultilineHandler, preventing multiline backspacing into previous lines and moving across lines.
  • Adds public boundary methods (moveLeft, moveRight, deleteLeft) to MultilineHandler and delegates to them from EditorActions when at line boundaries.
  • Reorders completer navigation in beforeKeypress to precede EditorActions, preventing duplicate character deletions on backspace while navigating completion previews.
  • Adds a dedicated integration test suite (test.multiline_editing.js) verifying multiline continuous backspaces, left/right arrow line transitions, and keybinding aliases (ctrl+h).

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

-I used Antigravity to research the root cause of the keypress event interception in @stdlib/repl and understand the code base


@stdlib-js/reviewers

@notstanzinn
notstanzinn requested a review from a team October 2, 2026 16:13
@stdlib-bot stdlib-bot added the REPL Issue or pull request specific to the project REPL. label Oct 2, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Oct 2, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. REPL Issue or pull request specific to the project REPL.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants