test: migrate stats/incr/nanhmean to ULP-based assertions - #15813
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PNYcx5kCt7DiG4WPRHH9xi --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Good First PR
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/nanhmeanfrom relative tolerance (EPS-scaled) assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value.Specifically, in
test/test.js:absand@stdlib/constants/float64/epsrequires with a singleisAlmostSameValuerequire.if ( actual === expected ) { ... } else { delta/tol ... }branch in the incremental harmonic mean test into a singlet.strictEqual( isAlmostSameValue( actual, expected, 1 ), true, 'returns expected value' );assertion.deltaandtolvariable declarations.The package has a single test file (
test/test.js); there is notest/test.native.js. The final assertion in the suite (t.equal( acc(), 1.6363636363636365, ... )) is an exact comparison against an exactly representable return value and is intentionally left unchanged.ULP bound:
1ULP.This was tightened to the measured minimum. Over the full fixture set (
[ 2.0, 3.0, NaN, 2.0, 4.0, NaN, 3.0, 4.0 ]), seven of the eight accumulator returns are bit-for-bit identical to the expected values (0 ULP) and the final return differs by exactly 1 ULP (2.769230769230769vs.2.7692307692307696). Accordingly,0fails and1passes, so1is the tightest admissible bound. The suite was run twice at the final bound to confirm determinism (13 passing, 0 failing in both runs).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
make test TESTS_FILTER=".*/stats/incr/nanhmean/.*"passes (13 passing).make lint-javascript-tests TESTS_FILTER=".*/stats/incr/nanhmean/.*"is clean.make lint-editorconfig-filescould not be run in this environment, as theeditorconfig-checkerbinary could not be downloaded. EditorConfig conformance was instead verified manually: the diff touches only tab-indented lines, introduces no trailing whitespace, and the file retains its final newline.lib/node_modules/@stdlib/stats/incr/nanhmean/test/test.js.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. Claude Code surveyed already-merged conversions in this family (e.g.
stats/incr/mhmean,stats/incr/nanmhmean) to mirror the established idiom, applied the mechanical substitution totest/test.js, measured the per-assertion ULP distances to determine the minimum bound, and verified the result by running the package test suite and the JavaScript test linter.@stdlib-js/reviewers
Generated by Claude Code