fix: resolve follow-up issues in blas/ext/base/ndarray - #15454
Draft
Planeshifter wants to merge 2 commits into
Draft
Planeshifter wants to merge 2 commits into
Planeshifter wants to merge 2 commits into
Conversation
The package heading and usage signature both read `gfillGreaterThanEqualEqual`, with a doubled `Equal`. Every other reference in the package -- the require line directly above the signature, `docs/repl.txt`, `docs/types/index.d.ts`, `lib/main.js`, and `package.json` -- uses `gfillGreaterThanEqual`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F5HbkjKMwKyrN7mThirjgQ
The namespace registered `dvander`, `gfillGreaterThanEqual`, `gleftPadCircular`, `gleftPadEdge`, `grightPadCircular`, `grightPadEdge`, `gvander`, and `gwhere` on `lib/index.js` without adding the corresponding entries to the namespace declaration, so the eight functions resolved at runtime but not from TypeScript. The other 223 members each carry an import and an interface member; add the same for these eight. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F5HbkjKMwKyrN7mThirjgQ
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetween 2026-09-22 12:31:02 -0700 and 2026-09-23 04:54:18 -0700.No related issue.
Description
This pull request:
fc9905c8: fix doubledEqualsuffix inlib/node_modules/@stdlib/blas/ext/base/ndarray/gfill-greater-than-equal/README.md— H1 (L21) and usage signature (L39) readgfillGreaterThanEqualEqual; corrected togfillGreaterThanEqualto matchlib/main.jsand the rest of the docs.ec5d60d6,cf2b5045, andf158b2ffeach added new members toblas/ext/base/ndarray's runtime namespace viasetReadOnlyinlib/index.jswithout updatinglib/node_modules/@stdlib/blas/ext/base/ndarray/docs/types/index.d.ts; runtime had 231 members, declarations only 223, sodvander,gfillGreaterThanEqual,gleftPadCircular,gleftPadEdge,grightPadCircular,grightPadEdge,gvander, andgwhereall failTS2339for TS consumers despite existing at runtime. Added the missing imports and<name>: typeof <name>;interface members (with JSDoc/@exampleadapted from each package's own.d.ts) at their alphabetical positions; counts now match at 231/231.Commits are grouped one per package directory:
blas/ext/base/ndarray/gfill-greater-than-equal(docs:) andblas/ext/base/ndarray(fix:).Related Issues
None.
Questions
No.
Other
Review scope. 37 first-parent commits, 196 files,
4e396e96^..f158b2ff. Themes: eight newblas/ext/base/ndarraypackages (gvander,dvander,gwhere,gfill-greater-than-equal,g{left,right}-pad-{edge,circular}) plus their namespace registrations; a float16 dtype rollout acrossarray/base/assert/*andndarray/base/{full,full-by,nans,nans-like}; nine ULP-assertion test migrations; a new C backend forstats/base/ndarray/dnanmeanpw; and lint/tooling work (ESLint flat-config for Markdown code blocks, new_tools/repl-txt/rules/no-redeclare).Validation. Checked for stdlib style-guide compliance (each new package diffed structurally against an established sibling —
blas/ext/base/ndarray/gfill-equalfor the ndarray wrappers,stats/base/ndarray/{dmeanpw,dnanmeanors}for the C addon) and scanned for bugs across the full window diff. Verified independently before committing: the namespace member counts (223 declared vs. 231 registered, the eight missing being exactly those added in this window), and the modified declaration file parsing clean undertsc --noEmitwith no new error classes relative to itsdevelopbaseline.Deliberately excluded. Anything requiring interpretation: subjective suggestions, style preferences not mandated by
docs/style-guides, and issues whose fix would reach outside the window's diff. Three candidates were dropped on that basis —8a518c59migrated onlyellipj/test/test.main.jsto ULP assertions, leavingtest.sncndn.js,test.assign.js, andtest.native.json the oldabs/EPSpattern; none of those three files is in the window's diff, and completing the migration would require deriving new ULP bounds, so it belongs in its own PR. Also dropped:gfill( len, 1.0, xbuf, 3 )ingfill-greater-than-equal/benchmark/benchmark.js, which indexes past thelen-elementxbufand grows the generic array to3*len-2. The measured work is stilllenelements becauseend = lenclips the range, so results are unaffected, and the pre-existing non-ndarrayblas/ext/base/gfill-greater-than-equalbenchmark uses the same pattern — changing only the new package would split the family. Flagging it here rather than fixing it unilaterally.The deliberate numeric reorderings in
fed47c5a(stats/base/dists/hypergeometric/mean,stats/base/dists/chi/skewness), the recalibrated ULP bounds, and thenew Array(W)→zeros(W)change instats/incr/mvmrwere all reviewed and left alone.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, as part of an automated review of the last 24 hours of commits to
develop. Reviewer agents surfaced the candidate issues; each finding was then re-verified against the tree before any edit, and the two findings that survived filtering are the ones applied here. Opened as a draft for maintainer audit.🤖 Generated with Claude Code
https://claude.ai/code/session_01F5HbkjKMwKyrN7mThirjgQ
Generated by Claude Code