Skip to content

fix: resolve follow-up issues in blas/ext/base/ndarray - #15454

Draft
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-09-23
Draft

Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-09-23

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Follow-up fixes for commits merged to develop between 2026-09-22 12:31:02 -0700 and 2026-09-23 04:54:18 -0700.

No related issue.

Description

What is the purpose of this pull request?

This pull request:

  • fc9905c8: fix doubled Equal suffix in lib/node_modules/@stdlib/blas/ext/base/ndarray/gfill-greater-than-equal/README.md — H1 (L21) and usage signature (L39) read gfillGreaterThanEqualEqual; corrected to gfillGreaterThanEqual to match lib/main.js and the rest of the docs.
  • ec5d60d6, cf2b5045, and f158b2ff each added new members to blas/ext/base/ndarray's runtime namespace via setReadOnly in lib/index.js without updating lib/node_modules/@stdlib/blas/ext/base/ndarray/docs/types/index.d.ts; runtime had 231 members, declarations only 223, so dvander, gfillGreaterThanEqual, gleftPadCircular, gleftPadEdge, grightPadCircular, grightPadEdge, gvander, and gwhere all fail TS2339 for TS consumers despite existing at runtime. Added the missing imports and <name>: typeof <name>; interface members (with JSDoc/@example adapted from each package's own .d.ts) at their alphabetical positions; counts now match at 231/231.

Commits are grouped one per package directory: blas/ext/base/ndarray/gfill-greater-than-equal (docs:) and blas/ext/base/ndarray (fix:).

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Review scope. 37 first-parent commits, 196 files, 4e396e96^..f158b2ff. Themes: eight new blas/ext/base/ndarray packages (gvander, dvander, gwhere, gfill-greater-than-equal, g{left,right}-pad-{edge,circular}) plus their namespace registrations; a float16 dtype rollout across array/base/assert/* and ndarray/base/{full,full-by,nans,nans-like}; nine ULP-assertion test migrations; a new C backend for stats/base/ndarray/dnanmeanpw; and lint/tooling work (ESLint flat-config for Markdown code blocks, new _tools/repl-txt/rules/no-redeclare).

Validation. Checked for stdlib style-guide compliance (each new package diffed structurally against an established sibling — blas/ext/base/ndarray/gfill-equal for the ndarray wrappers, stats/base/ndarray/{dmeanpw,dnanmeanors} for the C addon) and scanned for bugs across the full window diff. Verified independently before committing: the namespace member counts (223 declared vs. 231 registered, the eight missing being exactly those added in this window), and the modified declaration file parsing clean under tsc --noEmit with no new error classes relative to its develop baseline.

Deliberately excluded. Anything requiring interpretation: subjective suggestions, style preferences not mandated by docs/style-guides, and issues whose fix would reach outside the window's diff. Three candidates were dropped on that basis — 8a518c59 migrated only ellipj/test/test.main.js to ULP assertions, leaving test.sncndn.js, test.assign.js, and test.native.js on the old abs/EPS pattern; none of those three files is in the window's diff, and completing the migration would require deriving new ULP bounds, so it belongs in its own PR. Also dropped: gfill( len, 1.0, xbuf, 3 ) in gfill-greater-than-equal/benchmark/benchmark.js, which indexes past the len-element xbuf and grows the generic array to 3*len-2. The measured work is still len elements because end = len clips the range, so results are unaffected, and the pre-existing non-ndarray blas/ext/base/gfill-greater-than-equal benchmark uses the same pattern — changing only the new package would split the family. Flagging it here rather than fixing it unilaterally.

The deliberate numeric reorderings in fed47c5a (stats/base/dists/hypergeometric/mean, stats/base/dists/chi/skewness), the recalibrated ULP bounds, and the new Array(W)zeros(W) change in stats/incr/mvmr were all reviewed and left alone.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code, as part of an automated review of the last 24 hours of commits to develop. Reviewer agents surfaced the candidate issues; each finding was then re-verified against the tree before any edit, and the two findings that survived filtering are the ones applied here. Opened as a draft for maintainer audit.


🤖 Generated with Claude Code

https://claude.ai/code/session_01F5HbkjKMwKyrN7mThirjgQ


Generated by Claude Code

The package heading and usage signature both read
`gfillGreaterThanEqualEqual`, with a doubled `Equal`. Every other
reference in the package -- the require line directly above the
signature, `docs/repl.txt`, `docs/types/index.d.ts`, `lib/main.js`,
and `package.json` -- uses `gfillGreaterThanEqual`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F5HbkjKMwKyrN7mThirjgQ
The namespace registered `dvander`, `gfillGreaterThanEqual`,
`gleftPadCircular`, `gleftPadEdge`, `grightPadCircular`,
`grightPadEdge`, `gvander`, and `gwhere` on `lib/index.js` without
adding the corresponding entries to the namespace declaration, so the
eight functions resolved at runtime but not from TypeScript. The other
223 members each carry an import and an interface member; add the same
for these eight.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F5HbkjKMwKyrN7mThirjgQ
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 23, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray $\\color{red}29129/32547$
$\\color{green}+89.50\\%$
$\\color{red}473/483$
$\\color{green}+97.93\\%$
$\\color{red}0/241$
$\\color{green}+0.00\\%$
$\\color{red}29129/32547$
$\\color{green}+89.50\\%$
blas/ext/base/ndarray/gfill-greater-than-equal $\\color{green}167/167$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}167/167$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants