test: migrate stats/incr/skewness to ULP-based assertions - #15452
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vewx6nfMgR9fJUtfR1yJZg --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
@stdlib/stats/incr/skewnessfrom relative tolerance (EPS-scaled) assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires, along with the associateddelta/tolbookkeeping.Only
test/test.jsis modified; the package has notest/test.native.js. No implementation, fixture, documentation, or benchmark changes are included.ULP bounds
The package has two relative tolerance sites, covering four assertions in total:
the accumulator function incrementally computes a corrected sample skewness1.5 * EPS11if not provided an input value, the accumulator function returns the current corrected sample skewnessEPS11Starting from
64and tightening,1is the smallest bound which still passes. Every non-nullexpected value differs from the accumulated result by exactly one ULP:1.4578629673213051.45786296732130480.43666208457574880.436662084575748730.11718750.117187500000000011.9868296095909661.9868296095909659Re-running the suite at
0fails exactly those4of32assertions, confirming1is the minimum. The suite was run twice at the final bound, passing32/32both times.For reference, the sibling package
stats/incr/nanskewnessexercises the same expected values and also settled on1.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verified locally with
make test TESTS_FILTER=".*/stats/incr/skewness/.*"andmake lint-javascript-tests TESTS_FILTER=".*/stats/incr/skewness/.*".Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which selected the package, studied already-migrated packages to match the established idiom, performed the migration, and searched for the minimum passing ULP bound by measurement.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vewx6nfMgR9fJUtfR1yJZg
Generated by Claude Code