Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nn38mo1ttDvdih4R3d2yTA
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
@stdlib/stats/incr/pcorr2from relative tolerance (EPS-scaled) assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires, along with the associateddelta/tolbookkeeping.Only
test/test.jsis modified; the package has notest/test.native.js. No implementation, fixture, documentation, or benchmark changes are included.ULP bounds
Each bound was tightened to the measured minimum over the full set of test cases in its respective test block:
the accumulator function incrementally computes a square sample correlation coefficient88(worst case ati = 3andi = 4)the accumulator function incrementally computes a squared sample correlation coefficient (known means)33(worst case ati = 1)Lowering either bound by one (
7and2, respectively) fails three assertions, so both values are minimal. The suite was run twice at the final bounds, passing96/96both times, andeslintagainstetc/eslint/.eslintrc.tests.jsreports no findings.For reference, the sibling package
stats/incr/pcorr(which shares the same input data and expected values, unsquared) settled on4and1; squaring roughly doubles the relative error, which is consistent with the8and3measured here.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verified locally with
make test TESTS_FILTER=".*/stats/incr/pcorr2/.*".Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which selected the package, studied already-migrated packages to match the established idiom, performed the migration, and searched for the minimum passing ULP bounds by measurement.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01Nn38mo1ttDvdih4R3d2yTA
Generated by Claude Code