test: migrate stats/base/dists/f/cdf to ULP-based testing - #15405
Open
DivyanshuVortex wants to merge 1 commit into
Open
DivyanshuVortex wants to merge 1 commit into
DivyanshuVortex wants to merge 1 commit into
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/f/cdffrom relative tolerance testing to ULP difference testing, per [RFC]: Migrate math/base/special packages from relative tolerance testing to ULP difference testing (tracking issue) #11352.y === expected[i] / delta <= tolbranch in the Julia fixture loops oftest/test.cdf.jsandtest/test.factory.jswitht.strictEqual( isAlmostSameValue( y, expected[ i ], N ), true, 'returns expected value' );.@stdlib/assert/is-almost-same-valuerequire and drops the now unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.Final ULP constants (per fixture, identical across both test files):
both_large.json: 58 ULP (replaces50.0 * EPS)large_d1.json: 542 ULP (replaces400.0 * EPS)large_d2.json: 171 ULP (replaces200.0 * EPS)These bounds were determined empirically by measuring the maximal ULP difference across the full 1000-element Julia fixture sets.
Related Issues
This pull request has the following related issues:
Questions
No.
Other
Test results via
make test TESTS_FILTER=".*/stats/base/dists/f/cdf/.*":test.cdf.js3019 passing,test.factory.js3022 passing,test.js3 passing; 0 failing. All files have been updated to cleanly adhere to the new ULP guidelines without any unused variables left behind.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored with the help of an AI coding assistant (Gemini)
@stdlib-js/reviewers