Skip to content

test: migrate math/base/special/roundnf to ULP-based assertions #15357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
Sep 19, 2026
+23 −51
Merged

test: migrate math/base/special/roundnf to ULP-based assertions #15357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f66e357
test: migrate `math/base/special/roundnf` to ULP-based assertions
claude Sep 19, 2026
1e6bff1
docs: update comment
kgryte Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 12 additions & 26 deletions lib/node_modules/@stdlib/math/base/special/roundnf/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ var NINF = require( '@stdlib/constants/float32/ninf' );
var randu = require( '@stdlib/random/base/randu' );
var round = require( '@stdlib/math/base/special/round' );
var pow = require( '@stdlib/math/base/special/pow' );
var ulpdiff = require( '@stdlib/number/float32/base/ulp-difference' );
var isAlmostSameValue = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' );
var isPositiveZerof = require( '@stdlib/math/base/assert/is-positive-zerof' );
Expand Down Expand Up @@ -115,73 +115,62 @@ tape( 'the function returns `+0` if provided `+0`', function test( t ) {
tape( 'the function supports rounding a numeric value to a desired number of decimals', function test( t ) {
var expected;
var actual;
var delta;

actual = roundnf( PI, -2 );
expected = float64ToFloat32( 3.14 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( -PI, -2 );
expected = float64ToFloat32( -3.14 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( float64ToFloat32( 9.99999 ), -2 );
expected = float64ToFloat32( 10.0 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( float64ToFloat32( -9.99999 ), -2 );
expected = float64ToFloat32( -10.0 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( 0.0, 2 );
expected = 0.0;
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( float64ToFloat32( 12368.0 ), -3 );
expected = float64ToFloat32( 12368.0 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( float64ToFloat32( -12368.0 ), -3 );
expected = float64ToFloat32( -12368.0 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

t.end();
});

tape( 'rounding a numeric value to a desired number of decimals can result in unexpected behavior', function test( t ) {
var expected;
var actual;
var delta;
var x;

x = float64ToFloat32( 0.2 + 0.1 ); // => 0.30000000000000004 as float64, becomes 0.30000001192092896 as float32
x = float64ToFloat32( 0.2 + 0.1 ); // 0.30000000000000004 as float64, becomes 0.30000001192092896 as float32
actual = roundnf( x, -7 );
expected = float64ToFloat32( 0.3000000119209290 );
delta = ulpdiff( actual, expected );
t.ok( delta <= 1, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

t.end();
});

tape( 'the function supports rounding a numeric value to a desired number of digits', function test( t ) {
var expected;
var actual;
var delta;

actual = roundnf( PI, 3 );
expected = 0.0;
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( float64ToFloat32( 12368.0 ), 3 );
expected = float64ToFloat32( 12000.0 );
delta = ulpdiff( actual, expected );
t.ok( delta <= 1, 'returns expected value' );
t.strictEqual( isAlmostSameValue( actual, expected, 1 ), true, 'returns expected value' );

actual = roundnf( float64ToFloat32( 12368.0 ), 1 );
expected = float64ToFloat32( 12370.0 );
Expand All @@ -192,8 +181,7 @@ tape( 'the function supports rounding a numeric value to a desired number of dig

actual = roundnf( float64ToFloat32( -12368.0 ), 3 );
expected = float64ToFloat32( -12000.0 );
delta = ulpdiff( actual, expected );
t.ok( delta <= 1, 'returns expected value' );
t.strictEqual( isAlmostSameValue( actual, expected, 1 ), true, 'returns expected value' );

actual = roundnf( float64ToFloat32( -12368.0 ), 1 );
expected = float64ToFloat32( -12370.0 );
Expand Down Expand Up @@ -261,7 +249,6 @@ tape( 'if `n > 38` (exceeds float32 max exponent), the function returns `+-0` (s
tape( 'the function supports rounding very small numbers (including subnormals)', function test( t ) {
var expected;
var actual;
var delta;
var x;
var n;
var i;
Expand All @@ -287,8 +274,7 @@ tape( 'the function supports rounding very small numbers (including subnormals)'
for ( i = 0; i < n.length; i++ ) {
actual = roundnf( x, n[i] );
if ( i < expected.length ) {
delta = ulpdiff( actual, expected[i] );
t.ok( delta <= 2, 'x: '+x+'. n: '+n[i]+'. v: '+actual+'. expected: '+expected[i]+'. delta: '+delta+' ulps' );
t.strictEqual( isAlmostSameValue( actual, expected[i], 1 ), true, 'returns expected value' );
} else {
// Beyond float32 precision
t.ok( true, 'x: '+x+'. n: '+n[i]+'. v: '+actual );
Expand Down
36 changes: 11 additions & 25 deletions lib/node_modules/@stdlib/math/base/special/roundnf/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ var NINF = require( '@stdlib/constants/float32/ninf' );
var randu = require( '@stdlib/random/base/randu' );
var round = require( '@stdlib/math/base/special/round' );
var pow = require( '@stdlib/math/base/special/pow' );
var ulpdiff = require( '@stdlib/number/float32/base/ulp-difference' );
var isAlmostSameValue = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' );
var isPositiveZerof = require( '@stdlib/math/base/assert/is-positive-zerof' );
Expand Down Expand Up @@ -109,73 +109,62 @@ tape( 'the function returns `+0` if provided `+0`', opts, function test( t ) {
tape( 'the function supports rounding a numeric value to a desired number of decimals', opts, function test( t ) {
var expected;
var actual;
var delta;

actual = roundnf( PI, -2 );
expected = float64ToFloat32( 3.14 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( -PI, -2 );
expected = float64ToFloat32( -3.14 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( float64ToFloat32( 9.99999 ), -2 );
expected = float64ToFloat32( 10.0 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( float64ToFloat32( -9.99999 ), -2 );
expected = float64ToFloat32( -10.0 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( 0.0, 2 );
expected = 0.0;
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( float64ToFloat32( 12368.0 ), -3 );
expected = float64ToFloat32( 12368.0 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( float64ToFloat32( -12368.0 ), -3 );
expected = float64ToFloat32( -12368.0 );
delta = ulpdiff( actual, expected );
t.strictEqual( delta, 0, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

t.end();
});

tape( 'rounding a numeric value to a desired number of decimals can result in unexpected behavior', opts, function test( t ) {
var expected;
var actual;
var delta;
var x;

x = float64ToFloat32( 0.2 + 0.1 );
actual = roundnf( x, -7 );
expected = float64ToFloat32( 0.3000000119209290 );
delta = ulpdiff( actual, expected );
t.ok( delta <= 1, 'returns expected value' );
t.strictEqual( actual, expected, 'returns expected value' );

t.end();
});

tape( 'the function supports rounding a numeric value to a desired number of digits', opts, function test( t ) {
var expected;
var actual;
var delta;

actual = roundnf( PI, 3 );
expected = 0.0;
t.strictEqual( actual, expected, 'returns expected value' );

actual = roundnf( float64ToFloat32( 12368.0 ), 3 );
expected = float64ToFloat32( 12000.0 );
delta = ulpdiff( actual, expected );
t.ok( delta <= 1, 'returns expected value' );
t.strictEqual( isAlmostSameValue( actual, expected, 1 ), true, 'returns expected value' );

actual = roundnf( float64ToFloat32( 12368.0 ), 1 );
expected = float64ToFloat32( 12370.0 );
Expand All @@ -186,8 +175,7 @@ tape( 'the function supports rounding a numeric value to a desired number of dig

actual = roundnf( float64ToFloat32( -12368.0 ), 3 );
expected = float64ToFloat32( -12000.0 );
delta = ulpdiff( actual, expected );
t.ok( delta <= 1, 'returns expected value' );
t.strictEqual( isAlmostSameValue( actual, expected, 1 ), true, 'returns expected value' );

actual = roundnf( float64ToFloat32( -12368.0 ), 1 );
expected = float64ToFloat32( -12370.0 );
Expand Down Expand Up @@ -255,7 +243,6 @@ tape( 'if `n > 38` (exceeds float32 max exponent), the function returns `+-0` (s
tape( 'the function supports rounding very small numbers (including subnormals)', opts, function test( t ) {
var expected;
var actual;
var delta;
var x;
var n;
var i;
Expand All @@ -280,8 +267,7 @@ tape( 'the function supports rounding very small numbers (including subnormals)'
for ( i = 0; i < n.length; i++ ) {
actual = roundnf( x, n[i] );
if ( i < expected.length ) {
delta = ulpdiff( actual, expected[i] );
t.ok( delta <= 2, 'x: '+x+'. n: '+n[i]+'. v: '+actual+'. expected: '+expected[i]+'. delta: '+delta+' ulps' );
t.strictEqual( isAlmostSameValue( actual, expected[i], 1 ), true, 'returns expected value' );
} else {
t.ok( true, 'x: '+x+'. n: '+n[i]+'. v: '+actual );
}
Expand Down
Loading