Skip to content

docs: fix broken Markdown link (issue #11868) - #15351

Open
happy5318 wants to merge 1 commit into
stdlib-js:developfrom
happy5318:fix/11868-broken-cmudict-link
Open

happy5318 wants to merge 1 commit into
stdlib-js:developfrom
happy5318:fix/11868-broken-cmudict-link

Conversation

@happy5318

Copy link
Copy Markdown

Description

Fixes #11868

Replaces the broken link \http://www.speech.cs.cmu.edu/cgi-bin/cmudict#about\ in \lib/node_modules/@stdlib/datasets/cmudict/README.md\ with a Wayback Machine archived snapshot.

Root cause

The original URL only supports HTTP, but GitHub's automated markdown-link-check workflow defaults to HTTPS, which causes the link to be reported as broken (HTTP Status: 0 Failed). Routing through \web.archive.org\ preserves the original content while satisfying the HTTPS-only link checker.

Approach

  • Switched from \http://\ to \https://\ via Wayback Machine
  • Used the most recent archived snapshot (2024) for accuracy
  • Preserved the #about\ anchor so the in-page target still works
  • No other files modified

Verification

  • Local preview confirms link is functional and points to the original CMU CMUDict page via Wayback
  • Single-line change, no collateral damage
  • Resolves the failing link reported by automated workflow

Resolves #11868

Replaces http://www.speech.cs.cmu.edu/cgi-bin/cmudict#about with a Wayback Machine archived snapshot. The original URL only supports HTTP, but GitHub's markdown-link-check workflow defaults to HTTPS, causing the link to be reported as broken (HTTP 0). Routing through web.archive.org preserves the original content while satisfying the HTTPS-only link checker.

Fixes stdlib-js#11868
@happy5318
happy5318 requested a review from a team September 19, 2026 15:55
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. labels Sep 19, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix broken Markdown link: http://www.speech.cs.cmu.edu/cgi-bin/cmudict#about

2 participants