Conversation
Migrate the relative-tolerance assertions in the `factory` tests to ULP-difference assertions using `@stdlib/assert/is-almost-same-value`. All 3000 fixture values (1000 each across the `large_gamma`, `negative_median`, and `positive_median` fixtures) match the expected values bit-for-bit, so the minimum required ULP bound is 0. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012hgqZuiCHtonPPHkqjUiTE --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/cauchy/pdffrom relative tolerance testing to ULP difference testing, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.Only
test/test.factory.jscarried the relative-tolerance idiom (delta/tol/EPSwitht.ok( delta <= tol, ... )), across the three fixture loops. Those assertions are replaced withisAlmostSameValue, and the now-unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires are removed in favor of@stdlib/assert/is-almost-same-value.test/test.pdf.jsandtest/test.native.jsalready asserted exact equality viat.strictEqualand are intentionally left unchanged.Final ULP constant:
0(all three fixture loops).This is the measured minimum. All 3000 fixture values — 1000 each across
large_gamma,negative_median, andpositive_median— compare bit-for-bit identical to the expected values, for both thefactoryand main entry points, so no nonzero ULP budget is required. This is consistent withtest.pdf.js/test.native.jsalready relying on exact comparison, and matches the, 0 )bound used by previously migrated packages in this family.The bound was measured by exponential-then-binary search for the minimal passing
Nper fixture point, and the suite was then run three times at the final bound to confirm determinism (no FMA/arch variation).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification notes:
test/test.js,test/test.pdf.js, andtest/test.factory.jsall pass (3018 assertions in the migrated file);test/test.native.jsskips, as the native add-on is not built in this environment.pre-commithook.test/test.factory.js.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of a batch migration of relative-tolerance tests to ULP-based assertions, mirroring the idiom established in previously merged packages in this family (e.g.
stats/base/dists/cauchy/cdf). The ULP bound was measured rather than guessed.@stdlib-js/reviewers
Generated by Claude Code