Conversation
Replace relative tolerance comparisons with `isAlmostSameValue` ULP difference assertions, using the minimum required ULP value for each test case. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123sP14BeF6ekQw7pe3qbWB
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
|
An automated check found potentially unrelated issue/PR references in this PR:
Why this matters: GitHub automatically closes issues referenced with What to do:
This assessment was generated by an AI model and is informational only. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/chi2testfrom relative tolerance testing (delta <= tol, wheretol = N * EPS * abs( expected )) to ULP difference testing using@stdlib/assert/is-almost-same-value.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.Each assertion uses the measured minimum ULP value which still passes. Bounds were found by scanning upward from
0for every assertion and then confirming thatN-1fails:pValuestatisticndarray)The package has no
test/test.native.js, sotest/test.jsis the only test file changed.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification performed locally:
make test TESTS_FILTER=".*/stats/chi2test/.*"→ 72 passing, 0 failing. Run twice at the final ULP values to confirm determinism.make eslint-tests TESTS_FILTER=".*/stats/chi2test/.*"→ clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated, human-configured routine which converts one package per run. The ULP bounds were measured programmatically against the existing R fixtures rather than guessed.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_0123sP14BeF6ekQw7pe3qbWB
Generated by Claude Code