Conversation
Migrate the tests for `stats/incr/covmat` from relative tolerance (`EPS`-based) assertions to ULP difference assertions using `@stdlib/assert/is-almost-same-value`. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Phb6AirZLtqkmNsnamnQya
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
|
An automated check found potentially unrelated issue/PR references in this PR:
Why this matters: GitHub automatically closes issues referenced with What to do:
This assessment was generated by an AI model and is informational only. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/covmatfrom relative tolerance (EPS-based) assertions to ULP difference assertions using@stdlib/assert/is-almost-same-value.Details:
test/test.js. The package has notest/test.native.js, so only a single test file changed.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires, along with thedelta/toldeclarations and computations, replacing eachif ( v === e ) { ... } else { ... }tolerance block with a singlet.strictEqual( isAlmostSameValue( v, e, N ), true, 'returns expected value' );assertion.3for the twounbiased sample covariance matrix (order)and(covariance matrix)tests, and0for the two(means)tests.@stdlib/number/float64/base/ulp-difference, giving3,3,0, and0respectively. Each constant is the tightest possible bound: at2, the two3ULP tests fail (4 assertions), and0is the floor for the remaining two, where every value matches the Julia fixtures exactly. The previous relative tolerance was3.0 * EPSin all four blocks, which is consistent with a 3 ULP bound and was simply looser than necessary for the two(means)tests.make test TESTS_FILTER=".*/stats/incr/covmat/.*".etc/eslint/.eslintrc.tests.js) with 0 errors and 0 warnings.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which studied previously merged ULP migrations in the same package family (
stats/incr/mse,stats/incr/me), applied the same idiom here, and empirically measured and verified the minimum ULP bound for each assertion site.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01Phb6AirZLtqkmNsnamnQya
Generated by Claude Code