Skip to content

chore: fix JavaScript lint errors (issue #12359) - #15314

Open
SIDDARTHAREDDY8 wants to merge 1 commit into
stdlib-js:developfrom
SIDDARTHAREDDY8:oss-bhai-2026-09-17f
Open

SIDDARTHAREDDY8 wants to merge 1 commit into
stdlib-js:developfrom
SIDDARTHAREDDY8:oss-bhai-2026-09-17f

Conversation

@SIDDARTHAREDDY8

Copy link
Copy Markdown

Resolves #12359.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes the JavaScript lint error reported in Fix JavaScript lint errors #12359: stdlib/require-last-path-relative at 23:18 in lib/node_modules/@stdlib/math/base/tools/evalpoly-compile/examples/index.js ("Last require statement in example files must be a relative path").
  • Replaces the vestigial tryRequire( resolve( __dirname, '..', 'lib' ) ) loading pattern with a direct relative require( './../lib' ) as the last require statement, matching the convention used by the other pure-JavaScript tool examples (e.g., evalpoly). The package is pure JavaScript, so the graceful-degradation branch for unsupported environments was dead code.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Verification performed:

  • Reproduced the exact reported error locally with the repository's own require-last-path-relative rule implementation (23:18 error); after the fix the rule reports no errors.
  • node --check passes on the modified file.
  • Ran the example end-to-end against the real lib sources via the new relative require: it prints a compiled polynomial module, and the generated module was numerically validated against a direct Horner evaluation.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was developed with AI assistance (Muse). I used it to locate the rule implementation, reproduce the lint failure locally, draft the minimal fix consistent with repo conventions, and build the verification harness; I reviewed the final diff before submission.


@stdlib-js/reviewers

@SIDDARTHAREDDY8
SIDDARTHAREDDY8 requested a review from a team September 18, 2026 03:20
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants