test: migrate stats/base/dists/bradford/entropy to ULP-based assertions - #15294
Conversation
…ions Replaces the relative-tolerance comparisons (delta <= EPS * tol) in the test fixtures loop with `@stdlib/assert/is-almost-same-value`, tightened to the minimum ULP bound that passes deterministically. Ref: #11352 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DUn4JesAzgzP9FLBC6TTyv --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/bradford/entropyfrom relative-tolerance assertions (delta <= EPS * tol) to ULP-based assertions using@stdlib/assert/is-almost-same-value, per [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.test/test.jsandtest/test.native.js, the two fixture-driven test cases ("given small parameterc" and "given large parameterc") were converted. The minimum ULP bound that passes deterministically (verified over two consecutive runs) was found for each:cfixtures:1984ULP (the pre-existing tolerance of1523 * EPSwas already noted as high due to catastrophic cancellation in the nestedlncalculations for small shape parameters combined with very small expected values; that explanatory comment was preserved).cfixtures:64ULP.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only the two test files were changed; no source, docs, or
package.jsonchanges were needed since@stdlib/assert/is-almost-same-valueis an existing internal package.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, which searched for a candidate package, studied prior art from previously merged ULP-migration PRs, converted the test fixtures, and empirically determined the tightest passing ULP bounds.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01DUn4JesAzgzP9FLBC6TTyv
Generated by Claude Code