Skip to content

test: migrate stats/base/dists/bradford/entropy to ULP-based assertions - #15294

Merged
kgryte merged 1 commit into
developfrom
philipp/ulp-stats-base-dists-bradford-entropy
Sep 18, 2026
Merged

kgryte merged 1 commit into
developfrom
philipp/ulp-stats-base-dists-bradford-entropy

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates the test suite for stats/base/dists/bradford/entropy from relative-tolerance assertions (delta <= EPS * tol) to ULP-based assertions using @stdlib/assert/is-almost-same-value, per [RFC]: Migrate math/base/special packages from relative tolerance testing to ULP difference testing (tracking issue) #11352.
  • in test/test.js and test/test.native.js, the two fixture-driven test cases ("given small parameter c" and "given large parameter c") were converted. The minimum ULP bound that passes deterministically (verified over two consecutive runs) was found for each:
    • small c fixtures: 1984 ULP (the pre-existing tolerance of 1523 * EPS was already noted as high due to catastrophic cancellation in the nested ln calculations for small shape parameters combined with very small expected values; that explanatory comment was preserved).
    • large c fixtures: 64 ULP.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Only the two test files were changed; no source, docs, or package.json changes were needed since @stdlib/assert/is-almost-same-value is an existing internal package.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code, which searched for a candidate package, studied prior art from previously merged ULP-migration PRs, converted the test fixtures, and empirically determined the tightest passing ULP bounds.


@stdlib-js/reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_01DUn4JesAzgzP9FLBC6TTyv


Generated by Claude Code

…ions

Replaces the relative-tolerance comparisons (delta <= EPS * tol) in the
test fixtures loop with `@stdlib/assert/is-almost-same-value`, tightened
to the minimum ULP bound that passes deterministically.

Ref: #11352

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DUn4JesAzgzP9FLBC6TTyv

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Sep 17, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/bradford/entropy $\\color{green}172/172$
$\\color{green}+100.00\\%$
$\\color{green}8/8$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}172/172$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Sep 18, 2026
@kgryte
kgryte marked this pull request as ready for review September 18, 2026 06:33
@kgryte
kgryte requested a review from a team September 18, 2026 06:33
@kgryte
kgryte merged commit bb0b30f into develop Sep 18, 2026
66 checks passed
@kgryte
kgryte deleted the philipp/ulp-stats-base-dists-bradford-entropy branch September 18, 2026 06:34
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants