Add VerifiedAccount and VerifiedTransfer resources - #170
Merged
Merged
Conversation
edu-stark
previously approved these changes
Sep 17, 2026
…count_type The suite created five Verified Accounts for one fixed CPF while the API allows three per tax ID per 24 hours, so test_verified_transfer failed on this PR's own CI run. Bank-detail accounts now mint a distinct valid CPF per creation and the pix-key account is created once per run. VerifiedTransfer sent account_type, which the API's whitelist rejects as an unknown parameter; the parameter is removed from the resource and the fixture. The fixture also stops sending scheduled=datetime.now() (naive local time stamped as UTC). Four log docstring bullets gain the colon the grammar requires, and the README index lists the two new resources. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
edu-stark
force-pushed
the
feature/sdk-parity-equalization
branch
from
September 17, 2026 01:53
302b6e0 to
e14472f
Compare
edu-stark
previously approved these changes
Sep 17, 2026
edu-stark
left a comment
edu-stark
left a comment
Contributor
There was a problem hiding this comment.
Rebased onto master (the PR now runs the offline CI checks) and fixed the test failure: the suite created five Verified Accounts for one CPF against the API's three-per-tax-ID-per-24h cap — bank-detail accounts now mint a distinct valid CPF per creation and the pix-key account is created once per run. Also removed account_type (rejected by the API whitelist) from the VerifiedTransfer resource and fixture, dropped the naive scheduled=datetime.now(), added the four missing docstring colons and the README index bullets. Offline: compileall, flake8 E9/F63/F7/F82, import and fixture construction verified in a venv. Note: my approval does not satisfy the ruleset since I pushed last.
edu-stark
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
sdk-pythonto full resource parity withsdk-node(43/43), the reference SDK.Resources included
create,get,cancel,query,page+Log(get,query,page)create(reusestransfer.Rule)Contract source
Fields, methods, query filters and docstrings were taken from
sdk-nodeat7e70ecb, converted to snake_case and to the Python docstring convention. A code review compared every field and filter against the reference and found no divergence.Verification performed
python3 -c "import starkbank"resolvesstarkbank.VerifiedAccountandstarkbank.VerifiedTransferpy_compileclean on every new fileNot verified
Tests were written but not executed — no sandbox credentials were available in the environment where this was produced.
SANDBOX_ID,SANDBOX_PRIVATE_KEYand the organization pair are required. Please runtests/sdk/test_verified_account.py,test_verified_account_log.pyandtest_verified_transfer.pybefore merging.Review notes
Log.accountis parsed into aVerifiedAccountviafrom_api_json, following theinvoicepullrequestneighbour. The Node reference assigns the field raw.911.544.440-66,039.946.040-36) rather than a generator. An earlier draft usedTaxIdGenerator.taxId(), which returns a CNPJ about half the time and made the suite non-deterministic.🤖 Generated with Claude Code