Skip to content

fix: portal popover content - #124

Merged
starc007 merged 1 commit into
mainfrom
feat/popover-portal
Jul 27, 2026
Merged

fix: portal popover content#124
starc007 merged 1 commit into
mainfrom
feat/popover-portal

Conversation

@starc007

Copy link
Copy Markdown
Owner

What changed

  • render both Gooey and Morph Popover content through a body portal
  • keep portalled panels anchored to their triggers during scroll, resize, and close animations
  • preserve inside interactions and outside-click dismissal across the separate DOM trees
  • prevent the Gooey portal layer from covering the real trigger
  • add regression tests for clipping, positioning, and dismissal behavior

Why

Both popover variants were positioned inside their trigger wrapper. Ancestors with overflow: hidden or their own stacking context could clip or cover the panel.

The shared viewport-positioning helper lets each panel escape those ancestors without changing its existing animation path.

Validation

  • bun run check
  • bun test — 46 tests passed

@starc007
starc007 merged commit 8c4d70e into main Jul 27, 2026
2 checks passed
@starc007
starc007 deleted the feat/popover-portal branch July 27, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant