add gcp_adc dbt trino connection type#512
Open
artemboiko-data wants to merge 2 commits intostarburstdata:masterfrom
Open
add gcp_adc dbt trino connection type#512artemboiko-data wants to merge 2 commits intostarburstdata:masterfrom
artemboiko-data wants to merge 2 commits intostarburstdata:masterfrom
Conversation
Author
|
@damian3031 can you please take a look ? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR is related to #482 and trinodb/trino-python-client#466 (comment)
As we are working with GCP deployment, we are in real need to refresh JWT token for our long running ADC authenticated sessions.
Extra dependency is added for
pip install dbt-trino[gcp]installation.Example of similar approach used in BigQuery adapter
Checklist
README.mdupdated and added information about my changechangie newto create a changelog entry