fix: pass kebab menu data through a temporary file - #116
Open
cookerpapa wants to merge 1 commit into
Open
cookerpapa wants to merge 1 commit into
cookerpapa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111.
The kebab popup currently puts its full action list in the command line. This is the long-argument launch path identified in the report about menus being terminated on repeated opens.
Pass
{ paneName, actions }through the existing popup temporary-data mechanism and read that file in the popup entry point. Menu positioning, selection and result handling stay the same. The shared launcher removes the file on selection, cancellation and launch failure.Add regression coverage for the manager-to-file path, cleanup and the entry point's file loading/error handling. Update the existing anchor test for the new data argument and the already-current 26-row height limit.
Validation: